New completer subcommands GetType and GetParent #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puremourning
force-pushed
the
add-subcommands
branch
2 times, most recently
from
b827031
to
d31117e
Compare
| return "Unknown type"; | ||
|
|
||
| // | ||
| // |
There was a problem hiding this comment.
Remove these two empty commented-out lines.
|
I added some more minor comments, but this is looking good! |
GetType - returns the type of the word at a specific location. This is used by YouCompleteMe and echo'd in vim. Where the canonical type (the "derived" type, e.g. for a typedef) is different from the declared type, that is also returned, separated with " => ". GetParent - returns the semantic parent of the word at a specific location. This is also echo'd in vim by YouCompleteMe. One other change was required to satisty the cylomatic complexity check in the test suite: the if:elif: pattern in OnUserCommand was changed to a pythonic switch (a dictionary)
puremourning
force-pushed
the
add-subcommands
branch
from
d31117e
to
a00fe22
Compare
|
Updated as a00fe22 |
|
Thanks again! |
Valloric
added a commit
that referenced
this pull request
Feb 17, 2015
New completer subcommands GetType and GetParent
|
This appears to require recompiling the support library, but I didn't get a notification when I ran "BundleUpdate"; is this a bug? |
|
yes i think it might be. @Valloric how do you want to tackle this? |
|
I am so excited to be at the bleeding edge of YCM functionality. :D |
|
Ah, seems we forgot to bump the internal API version numbers. I'll get on it. |
Valloric
added a commit
that referenced
this pull request
Mar 7, 2015
|
OK, updated both ycmd and YCM. The message about recompiling should show up after syncing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetType - returns the type of the word at a specific location. This is used by
YouCompleteMe and echo'd in vim. Where the canonical type (the "derived" type,
e.g. for a typedef) is different from the declared type, that is also returned,
separated with " => ".
GetParent - returns the semantic parent of the word at a specific location.
This is also echo'd in vim by YouCompleteMe.
One other change was required to satisty the cylomatic complexity check in the
test suite: the if:elif: pattern in OnUserCommand was changed to a pythonic
switch (a dictionary)
see also #87 for details and history.