Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement KeyValues3 (Text) #5

Open
yaakov-h opened this issue Mar 29, 2016 · 1 comment · May be fixed by #61
Open

Implement KeyValues3 (Text) #5

yaakov-h opened this issue Mar 29, 2016 · 1 comment · May be fixed by #61
Labels
enhancement KV 3️⃣
Projects
Key Values 3

Comments

@yaakov-h
Copy link
Member

yaakov-h commented Mar 29, 2016 •
edited by xPaw

EDIT: Checklist move to #61
@xPaw
Copy link
Member

xPaw commented Apr 16, 2020

KV3 text is implemented here, and I think it has no known issues: https://github.com/SteamDatabase/ValveResourceFormat/tree/master/ValveResourceFormat/Serialization/KeyValues

KV3 binary: https://github.com/SteamDatabase/ValveResourceFormat/blob/master/ValveResourceFormat/Resource/ResourceTypes/BinaryKV3.cs

Binary is slightly complicated due to multiple compressions and versions, but luckily all of that has been figured out by now.

The only issue there is the ConvertBinaryOnlyKVType function because binary kv3 has some special types (like bytes for true/false booleans and uint32 in binary which maps to uint64 in the text one).

@xPaw xPaw linked a pull request Dec 5, 2022 that will close this issue
Implement text KeyValues 3 #61
Draft
14 tasks
@xPaw xPaw changed the title Implement KeyValues3 Implement KeyValues3 (Text) Mar 6, 2023
@xPaw xPaw mentioned this issue Mar 6, 2023
Open
@xPaw xPaw removed the roadmap item label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement KV 3️⃣
Projects
Key Values 3
Status: In Progress
Key Values 3
  
In Progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement text KeyValues 3 ValveResourceFormat/ValveKeyValue
2 participants
@yaakov-h @xPaw