Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure dist.lock management does not break system-wide installs #3844

Closed
2 tasks done
414n opened this issue May 8, 2020 · 1 comment
Closed
2 tasks done

Ensure dist.lock management does not break system-wide installs #3844

414n opened this issue May 8, 2020 · 1 comment
Labels
Feature Request New feature or request

Comments

@414n
Copy link

414n commented May 8, 2020

Feature Request

I confirm:

  • that I haven't found another request for this feature.
  • that I have checked whether there are updates for my system available that
    contain this feature already.

Description

The proton python script currently creates a lock file based on the base_dir location. This works ok for "mainstream" Proton installs, as they get installed by the Steam client in the SteamApps directory where the user must have write access to; however, this can break in Proton versions installed under system-wide compatibilitytools.d directories such as /usr/share/steam or /usr/local/share/steam, because there the user could have no write access to create that lock file.
A solution could be to check for write access in base_dir before attempting to create the lock file in there, resorting to another writable location or to directly use the /var/lock directory in all cases.
Using a directory other than base_dir poses the problem of having a unique ID for the lock file at one's disposal, but I think this can be done by using the CURRENT_PREFIX_VERSION variable.

Justification

This issue is for the proton script, that is not part of standard wine

Risks

Choosing a bogus ID for the lock file could mean possible concurrent access to the prefix that should have been blocked by the lock file.

References

ValveSoftware/steam-for-linux#6310

@kisak-valve kisak-valve added the Feature Request New feature or request label May 8, 2020
@414n 414n changed the title Move Proton dist.lock file to /var/lock Ensure dist.lock management does not break system-wide installs May 12, 2020
@414n
Copy link
Author

414n commented Jun 9, 2020

Fixed in 6e821c7

@414n 414n closed this as completed Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants