Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INVERSUS Deluxe (432980) #5710

Open
2 tasks done
James76931 opened this issue Mar 22, 2022 · 12 comments
Open
2 tasks done

INVERSUS Deluxe (432980) #5710

James76931 opened this issue Mar 22, 2022 · 12 comments
Labels
Game compatibility - Unofficial Games not expected to work without issues

Comments

@James76931
Copy link

James76931 commented Mar 22, 2022

Compatibility Report

  • Name of the game with compatibility issues: INVERSUS Deluxe
  • Steam AppID of the game: 432980

System Information

Steam Deck 512GB

I confirm:

  • that I haven't found an existing compatibility report for this game.
  • that I have checked whether there are updates for my system available.

(Logs captured when game is launched using DirectX 11)
Proton experimental-7.0-20220310:steam-432980.log

Proton 4.2-9: steam-432980.log

Symptoms

In Proton versions 7.0-1, Experimental, and 6.3-8, INVERSUS Deluxe typically fails to start. The screen briefly flashes white and the game closes. On the odd occasion that INVERSUS Deluxe boots properly, gamepad input fails to be recognised.
Proton 4.2-9 appears to work significantly better, with every aspect of the game functioning minus audio output.

Reproduction

Download the game on a Steam Deck (512GB), run it, and if using Proton 4.2-9 turn up system volume.

@James76931
Copy link
Author

James76931 commented Mar 23, 2022

Proton versions 4.11-13, 5.0-10, and 5.13-6 appear to have the same issues as 6.3-8 and above.

The game does not start in Proton 4.2-9 when launched using DirectX 9 but no white screen is displayed.

@kisak-valve kisak-valve added the Game compatibility - Unofficial Games not expected to work without issues label Mar 23, 2022
@kisak-valve
Copy link
Member

Hello @James76931, wine: Call from 7B011197 to unimplemented function hid.dll.HidD_GetPhysicalDescriptor, aborting looks like the line of interest from your log.

@Blisto91
Copy link

Looks like it's not implemented in wine.
https://docs.microsoft.com/en-us/windows-hardware/drivers/ddi/hidsdi/nf-hidsdi-hidd_getphysicaldescriptor

Probably need a upstream wine issue for that one.

@mohamadaljaf
Copy link

Hi, I submitted a patch for this issue to Wine: https://source.winehq.org/patches/data/231171

Hopefully it will fix your issue. :)

Also, @kisak-valve is there a way to submit this patch to Proton?

@alasky17
Copy link
Collaborator

@mohamadaljaf Nice work! I see it just got accepted upstream today. IMO you already followed the best way to submit it to Proton :D If nothing else, all upstreamed patches are picked up automatically with the next wine rebase. Since we know this fixes a particular game, we can cherry-pick it now quite easily. I actually just tested the cherry-pick, and it seems to fix the crash on launch, so I will make sure it gets in the next experimental release :) You can potentially also submit a pull request for the upstreamed patch, but I'm not sure myself quite how to do that for a wine patch.

@mohamadaljaf
Copy link

Awesome, glad it fixed the crash. Thanks, I'll look into submitting a pull request. :)

@alasky17
Copy link
Collaborator

@mohamadaljaf Your patch is in the latest experimental release as of today :D It is really quite easy for us to pull patches into proton once they are upstreamed :) IMO for already upstreamed work in Wine, the pull request option is available in case a ping doesn't catch someones attention.

@James76931
Copy link
Author

Thank you so much @mohamadljaf! I've spent some time testing and I can say the game runs flawlessly on the latest Proton Experimental (using either DirectX 11 or 9) which is wonderful. Really feels great to play on the Steam Deck. There are no crashes when launched, no input or sound issues, no stuttering/degraded performance, and everything is accessible. @alasky17 or @kisak-valve, assuming it's appropriate to ask without creating a new issue, would it please be possible to get a whitelist for this game (and perhaps a cheeky nudge to the Deck Verified team 😅😆)?

@alasky17
Copy link
Collaborator

@James76931 Great to hear :D Since this game is now on my radar as improved behavior over 7.0-1, it actually already in the queue to get tested/retested by the team that does deck verification :)

@James76931
Copy link
Author

@alasky17 Ah that's great :D Do you think it's a good idea to keep this issue open for whitelisting then? I'm just thinking if the game would be whitelisted anyway once you've confirmed how well it works with Proton through your tests on the Deck. Or is it even worth requesting it be whitelisted in the first place? This is my first time reporting an issue here so I'm not 100% sure of the next steps once a previously buggy game becomes fully working 😛

@mohamadaljaf
Copy link

@mohamadaljaf Your patch is in the latest experimental release as of today :D It is really quite easy for us to pull patches into proton once they are upstreamed :) IMO for already upstreamed work in Wine, the pull request option is available in case a ping doesn't catch someones attention.

I see, I suppose there's no reason to submit a pull request anymore.

Feel free to ping me in the future if a game crashes on an unimplemented function. Often, a stub is enough to get them running.

@Blisto91
Copy link

Blisto91 commented Apr 1, 2022

@alasky17 Ah that's great :D Do you think it's a good idea to keep this issue open for whitelisting then?

You can just keep the issue open in general. Then people can post here in they run into another problem :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Game compatibility - Unofficial Games not expected to work without issues
Projects
None yet
Development

No branches or pull requests

5 participants