Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTSync for bleeding-edge #7501

Open
2 tasks done
UbuntuGaming opened this issue Feb 17, 2024 · 8 comments
Open
2 tasks done

NTSync for bleeding-edge #7501

UbuntuGaming opened this issue Feb 17, 2024 · 8 comments
Labels
Feature Request New feature or request

Comments

@UbuntuGaming
Copy link

UbuntuGaming commented Feb 17, 2024

Feature Request (Bleeding-Edge)

NTSYNC (Current version is 5)

I confirm:

  • that I haven't found another request for this feature.
  • that I have checked whether there are updates for my system available that
    contain this feature already.

Description

NTSYNC
NTSync

Files

NTsync (Wine)
https://repo.or.cz/wine/zf.git/shortlog/refs/heads/ntsync5

NTSync (Kernel) > To be sent to the Deck kernel team if you choose to implement the feature
https://repo.or.cz/linux/zf.git/shortlog/refs/heads/ntsync5

Thanks for reading :)

@kisak-valve kisak-valve added the Feature Request New feature or request label Feb 17, 2024
@Leopard1907
Copy link

That chart is misleading as it compares against wineserver which you normally do not use but use esync and fsync ( if available always fsync is used , which is since some 5.x kernel, other than some app workarounds that disables fsync ).

Ntsync vs fsync is barely an improvement in many cases.

@DekosAnjo
Copy link

The primary objective of NTsync is not merely to enhance speed but rather to prioritize compatibility, ensuring seamless operation at the same speed or even surpassing it.

@UbuntuGaming
Copy link
Author

UbuntuGaming commented Feb 19, 2024

My apologies.
I uploaded the image as i saw it on my hard drive & i wanted to put in a request for the feature, before i forgot about it again.
I was sure the proton devs would of done testing of their own to determine if it was worth it or not.
From what I've seen it does very slightly improve performance over fsync.
I tested it for a single application under wine & saw a 3-7fps stable increase not much comparing i was already at 900-1000+ fps but still an measurable improvement. I will do more testing with it in the next week or the week after & i will attach my findings here in this comment.
It also might work with the few games that don't play nice with fsync.

Next time i won't rush the request & i will either write a more proper description or leave the description field blank.
Thanks for the comments 🙂

@SoongVilda
Copy link

I tested NTsync vs Fsync on proton-cachyos and performance improvements in terms of fps aren't high, is just around 5 fps, but I noticed much more stable frametimes and less latency, games feels more responsive than on fsync.

@Cederick
Copy link

I'd also argue that every boost to performance and stability in games should be a priority for Valve since this will be a step that would get some games from almost playable to be playable. And getting a little more stability for a ton of games means that it's also a small boost to the general user experience. So I hope this will get implemented.

@simifor
Copy link

simifor commented Feb 26, 2024

it should be noted that this also requires kernel support and the patchset isn't upstream yet so very few people would be able to make use of this at this time

@damentz
Copy link

damentz commented Apr 14, 2024

It looks like ntsync is going upstream, Greg KH already added the first 3 patches of 30 for this feature: https://lore.kernel.org/lkml/2024041141-renter-boring-9ff2@gregkh/. Would be nice to get some support in Proton Experimental to test out, should improve compatibility with games too where fsync/esync fall short.

@frozen-sea
Copy link

I tested NTsync vs Fsync on proton-cachyos and performance improvements in terms of fps aren't high, is just around 5 fps, but I noticed much more stable frametimes and less latency, games feels more responsive than on fsync.

This comment got me curious and my testing agrees with this. I tried to keep this reasonable by running the games at settings that don't cause the rendering to become primarily CPU-bound, since that's usually how people actually run them.

Quick specs:

  • Ryzen 5800X3D
  • RTX 4070Ti
  • winesync-dkms 5.16-5
  • proton-cachyos 9.0-11

Screenshot_20240509_160356

Any significant improvement to game smoothness is a big win in my book, because it's currently in a terrible state. This and a more appropriate scheduler currently seem to be where those improvements can be made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request New feature or request
Projects
None yet
Development

No branches or pull requests

9 participants