Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fps_override "value" should be saved when changed. #2237

Closed
basuritashka opened this issue Apr 24, 2019 · 52 comments
Closed

fps_override "value" should be saved when changed. #2237

basuritashka opened this issue Apr 24, 2019 · 52 comments
Assignees

Comments

@basuritashka
Copy link

@basuritashka basuritashka commented Apr 24, 2019

As a 144hz user, it's frustrating to define fps_override 1 to get >100 FPS on each CS startup. (without using a .cfg)

@2010kohtep

This comment has been minimized.

Copy link

@2010kohtep 2010kohtep commented Apr 24, 2019

The fix is quite simple, just add the FCVAR_ARCHIVE flag to the fps_override variable. @mikela-valve, why not? :)

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented Apr 24, 2019

I was going to say the same thing. I’m fine making that and any other cvar’s FCVAR_ARCHIVE that make sense to be automatically persisted unless there are any reasons not to.

Sent with GitHawk

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Apr 24, 2019

I dont know if there are more useful cvars that are not being saved, but I would like to have "fps_override" as a permanent change if his value gets changed. My monitor would be very grateful :)

@FEDERICOMB96

This comment has been minimized.

Copy link

@FEDERICOMB96 FEDERICOMB96 commented Apr 24, 2019

cl_showfps should get saved too as its more simple than net_graph, also it just use a little space of your screen

@djdallmann

This comment has been minimized.

Copy link

@djdallmann djdallmann commented Apr 24, 2019

And perhaps gl_ansio and cl_filterstuffcmd :)

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Apr 24, 2019

If someone else knows more useful cvars that can be added into the FCVAR_ARCHIVE param. we can make a great list to @mikela-valve

@mikela-valve mikela-valve self-assigned this Apr 24, 2019
@mikela-valve mikela-valve added this to the Next Release milestone Apr 24, 2019
@MOCOLONI

This comment has been minimized.

Copy link

@MOCOLONI MOCOLONI commented Apr 24, 2019

If someone else knows more useful cvars that can be added into the FCVAR_ARCHIVE param. we can make a great list to @mikela-valve

spec_mode & spec_mode_internal seem not get saved even if values are specified in an autoexec file. For example, a value of '3' for both commands means you spectate the target through 'Free Chase Camera' mode. However, every time the game is restarted, the mode is set to 'Free Look'. Pressing Space will be switching between all modes except 'Free Chase Camera' for some reason, which is the one I want to be defaulted to. I can use Ctrl and manually selecting the mode, but it's something I have to do all the time and for some reason its value seems not to be saved in any way and works only when submitted while in a game.

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Apr 24, 2019

graphheight and gl_texturemode needs to be FCVAR_ARCHIVE also.

Quick edit.

@Sockman1

This comment has been minimized.

Copy link

@Sockman1 Sockman1 commented Apr 24, 2019

gl_texturemode should probably be saved as well.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented Apr 25, 2019

It looks like the list so far is:

  • fps_override
  • cl_showfps
  • gl_ansio
  • cl_filterstuffcmd
  • spec_mode
  • graphheight
  • gl_texturemode
  • ex_interp
  • gl_round_down
  • gl_max_size
  • gl_picmip
  • gl_waterramp
  • gl_spriteblend
  • gl_dither
  • gl_keeptjunctions
  • gl_lightholes
  • violence_ablood
  • violence_agibs
  • violence_hblood
  • violence_hgibs
  • zoom_sensitivity_ratio
  • hud_deathnotice_time
  • default_fov
  • cl_bob
  • room_off
  • rate
  • r_decals
  • max_shells
  • max_smokepuffs
  • cl_smoothtime

I know gl_texturemode at least is actually a command and not a cvar so it can't be trivially saved but I'll see what I can do about that and the rest of these.

@PredatorFly

This comment has been minimized.

Copy link

@PredatorFly PredatorFly commented Apr 25, 2019

ex_interp plz

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Apr 26, 2019

If you don't mind, maybe we can add:
gl_round_down
gl_max_size
gl_picmip
gl_waterramp
gl_spriteblend
gl_dither
gl_keeptjunctions
gl_lightholes
violence_ablood
violence_agibs
violence_hblood
violence_hgibs

@Sockman1

This comment has been minimized.

Copy link

@Sockman1 Sockman1 commented Apr 26, 2019

I think dev commands like gl_wireframe, sv_cheats, and developer should be kept unarchived so it's easier to restore everything. When I use something like gl_wireframe, for instance, I'm looking for a bug or error, and when I'm done I don't want to try to remember every option I changed and change it back. If you really need to keep these persistent, using launch options works just as well.

@tschumann

This comment has been minimized.

Copy link

@tschumann tschumann commented Apr 26, 2019

I agree - debug cvars should not be persisted.

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Apr 26, 2019

Removed some dev cvars thanks to @Sockman1 and @tschumann

@dager10

This comment has been minimized.

Copy link

@dager10 dager10 commented Apr 28, 2019

zoom_sensitivity_ratio should be saved too and probably hud_deathnotice_time as well

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 14, 2019

I've added everything noted with the exception of spec_mode/spec_mode_internal as those are actually commands that have multiple parameters and aren't as conducive to being converted to cvars.

gl_texturemode was converted from a command to a cvar so it can be saved automatically through FCVAR_ARCHIVE.

@MOCOLONI

This comment has been minimized.

Copy link

@MOCOLONI MOCOLONI commented May 15, 2019

I've added everything noted with the exception of spec_mode/spec_mode_internal as those are actually commands that have multiple parameters and aren't as conducive to being converted to cvars.

gl_texturemode was converted from a command to a cvar so it can be saved automatically through FCVAR_ARCHIVE.

Just like with "net_graph 0/1/2/3", I thought it would be possible and a good idea for the game to remember the camera mode that was last used.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 15, 2019

@MOCOLONI Actually it looks like spec_mode_internal (and spec_pip) are already archived and are the default reset values for spec_mode. Does setting those to the values you'd use for spec_mode not get it to default to the right view?

@MOCOLONI

This comment has been minimized.

Copy link

@MOCOLONI MOCOLONI commented May 15, 2019

@MOCOLONI Actually it looks like spec_mode_internal (and spec_pip) are already archived and are the default reset values for spec_mode. Does setting those to the values you'd use for spec_mode not get it to default to the right view?

Without config files like "autoexec.cfg" nor "userconfig.cfg" it doesn't seem to get saved. I then tried listing them into the "autoexec" one and, like before, it still won't work. However, it Does seem to read the value from the "userconfig.cfg" file.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 15, 2019

@MOCOLONI Could you check your (presuming this is CS) cstrike\config.cfg after setting spec_mode_internal/spec_pip and see if they're written there?

Archived cvar's are saved to config.cfg, and the order that the configs are loaded in is:

  1. autoexec.cfg
  2. config.cfg
  3. userconfig.cfg
  4. game.cfg
@MOCOLONI

This comment has been minimized.

Copy link

@MOCOLONI MOCOLONI commented May 15, 2019

@mikela-valve Yes, they are.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 15, 2019

Does it just not matter what they're set to (i.e. they're set the same values as your last run but they don't set spec_mode correctly) or do they get set to default values (0 or 1) each time?

@MOCOLONI

This comment has been minimized.

Copy link

@MOCOLONI MOCOLONI commented May 15, 2019

@mikela-valve I recently joined the beta (though not for the first time) and ever since I found out, just now, that not even the userconfig.cfg file is necessary anymore; both the spec_mode and spec_pip commands get their last-used values stored in the "config.cfg" file. Before, at least for spec_mode, it would always reset to "1".

@hobokenn

This comment has been minimized.

Copy link

@hobokenn hobokenn commented May 17, 2019

If it's not too late default_fov, cl_bob and room_off would be nice to have archived.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 17, 2019

I think those all sound fine, thanks!

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 21, 2019

Fixed in beta 'Exe build: 11:12:36 May 21 2019 (8244)'.

@MOCOLONI

This comment has been minimized.

Copy link

@MOCOLONI MOCOLONI commented May 21, 2019

@mikela-valve The latest update seems not to show the progress of a connection to the server; it instead leaves a blank (dark) background while loading everything.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 21, 2019

Thanks @MOCOLONI, that was a regression in fixing #2124 that should be fixed later today.

@di57inct

This comment has been minimized.

Copy link

@di57inct di57inct commented May 21, 2019

@mikela-valve please do the same for cl_filterstuffcmd and rate cvars.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 21, 2019

Sure, I can add rate. cl_filterstuffcmd is already an archived cvar.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 23, 2019

rate has been added as of beta 'Exe build: 16:32:50 May 22 2019 (8245)'.

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented May 23, 2019

@mikela-valve I am sure rate was already an archived cvar.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 23, 2019

rate was not an archived cvar, though it may have been in the past. Were you possibly thinking of cl_updaterate which is already one?

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented May 23, 2019

On Exe build: 15:58:59 Apr 3 2019 (8196) rate gets saved when closing Counter-Strike 1.6

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented May 23, 2019

@mikela-valve btw, beta seems to be not working properly.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 23, 2019

It looks like you're right, rate does get saved but not as a cvar, it's saved to hl.conf which gets applied as the rate in any HL-based game that you run. It looks like that value gets loaded after the config files do as well, so I may change it to not set the rate from that file if it has already been set from a user config.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 23, 2019

What isn't working in the beta?

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented May 23, 2019

I am on beta according to Steam but in-game I got this version:
Exe build: 15:58:59 Apr 3 2019 (8196)

imagen

imagen

Note: I was switching between beta and normal CS to test some things. weird.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 23, 2019

Oh, that may be due to CS being on beta but not HL1. They're supposed to switch together when you change between beta and public but sometimes that doesn't work. Try switching in and out of beta for HL.

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented May 23, 2019

You are right, but if you got only Counter-Strike 1.6 on your Library, beta won't work at all unless you got HL bought too into your library, that should be intended right?

(I tested it on 2 different Steam accounts, HL plus CS 1.6, works flawlessly and CS 1.6 without HL, beta doesn't work)

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented May 23, 2019

Yep, that’s as expected. Any shared engine changes and other shared code will only be in the HL1 depots, so if you’re only opted in to beta in CS you would have beta versions for whichever CS-specific files are in beta but not any of the shared files.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented Jun 2, 2019

Closing as fixed.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented Jul 19, 2019

Added r_decals, max_shells, max_smokepuffs, cl_smoothtime from #2595 (comment)

@h0lzed

This comment has been minimized.

Copy link

@h0lzed h0lzed commented Jul 20, 2019

@mikela-valve r_decals still not archived.

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Jul 20, 2019

@mikela-valve r_decals still not archived.

Can confirm, r_decals is not FCVAR_ARCHIVE.

@h0lzed

This comment has been minimized.

Copy link

@h0lzed h0lzed commented Jul 20, 2019

Probably it works, but just a little bit strange.
In menu it shows r_decals 4096, but after connecting to a server it shows 0.

@SamVanheer

This comment has been minimized.

Copy link

@SamVanheer SamVanheer commented Jul 20, 2019

Indeed it isn't archived, however if you join a multiplayer game and r_decals is greater than mp_decals it forces the value of r_decals to that of mp_decals. mp_decals defaults to 300, and it's also marked as archived.

@mikela-valve

This comment has been minimized.

Copy link
Collaborator

@mikela-valve mikela-valve commented Jul 23, 2019

@SamVanheer Thanks, I checked that out after reading your comment and changed the way r_decals was handled a bit. Rather than making r_decals an archived cvar, since that wouldn't have worked well with mp_decals resetting it, I introduced a single-player analog to it, sp_decals that is used when starting a single-player server.

I also removed the check for setting r_decals only if mp_decals or sp_decals is smaller, instead r_decals is always set to the current value of mp_decals or sp_decals on server init, and both mp_decals and sp_decals are archived.

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Jul 24, 2019

@mikela-valve The change to *_decals seems to be working great.

If possible to make the following commands as FCVAR_ARCHIVE
con_shifttoggleconsole
con_notifytime
loadas8bit
CFG/.txt related commands
logsdir
lservercfgfile
mapchangecfgfile
mapcyclefile
servercfgfile

@basuritashka

This comment has been minimized.

Copy link
Author

@basuritashka basuritashka commented Jul 27, 2019

Part 2 - commands that should be saved.

motdfile
net_log
nosound

@h0lzed

This comment has been minimized.

Copy link

@h0lzed h0lzed commented Jul 29, 2019

r_mmx should be archived.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.