[Opposing Force] Hornet Gun is broken

[BlackShadow]

Opposing Force have some issues with Hornet Gun

Draw and Fire animations are not working properly.
When you run out of ammo, firing sound plays twice.
Sometimes firing sound is completely incorrect.

https://streamable.com/vse2a

As in the video setting cl_lw to "0" fixes firing behaviour but not the draw animation.

[JoelTroch]

Potential duplicate of #1621

[agrastiOs]

Related to #617, also @JoelTroch your issue only mentions HL1 and not OP4

[SamVanheer]

The attack issue is already covered by #556

The deploy animation is getting cut off because the Opposing Force version of the Hornet Gun wasn't updated to use weapon prediction correctly.

This line:

halflife/dlls/hornetgun.cpp

Line 282 in c7240b9

if (m_flTimeWeaponIdle > UTIL_WeaponTimeBase())

Still looks like this in Opposing Force:

if (m_flTimeWeaponIdle > gpGlobals->time)

Changing it to use UTIL_WeaponTimeBase() should fix it.

Based on the SDK changes this wasn't fixed until SDK 2.3, so when it was fixed it must've not been fixed in Op4 at the same time. Blue Shift's version has the fix so it's just Op4.