cl_autowepswitch not working in Half-Life 1

[TheStormN]

The Half-Life 1 update from 08.10.2019 added the long awaited client command "cl_autowepswitch" which for example CS had for... lets say forever. Anyway it is buggy, randomly stops working, especially after you are killed and respawn. The new update from this Friday does not fix it... Could you please fix it?

[afwn90cj93201nixr2e1re]

@mikela-valve can you also fix something?
Add check is there IN_Attack flag - then skip switching, that's really anoying when i walking with knife and c4 dropped out at ground.

[TheStormN]

@mikela-valve Anything new on this? I can confirm that after a respawn the command does not have any effect.

[mikela-valve]

Hi @TheStormN, this should be fixed in the current beta version 8308.

[afwn90cj93201nixr2e1re]

Did you add in_attack condition?
Coz it's really sometimes became useless to picking up some weapons when you shooting due weapon changes coz some weapons more powerfull than others.

I mean maybe you could add new cvar and add one more checkbox inside settings?

[TheStormN]

@mikela-valve Thank you, it is fixed!

Just a note - I would prefer to be spawn holding the pistol, instead of the crowbar. :)

[mikela-valve]

@TheStormN That's a good point, I noticed that just now as well when I was checking something. I'll change the spawn behaviour specifically to ignore cl_autowepswitch for the initial weapon loadout.

@afwn90cj93201nixr2e1re That sounds fine to me, I'll add another cvar cl_autowepswitchinattack to toggle that.

[afwn90cj93201nixr2e1re]

You know what?? Possible it's gonna be better if you keep use same cvar, but extend values, 1.0 - always, 2.0 - if not in attack something like that.

[mikela-valve]

I thought about that but didn't want to make that cvar confusing. 2 is actually already in use in DMC to mean auto-swap if the weapon is better (DMC also has 1 to signify always auto-swap).

[afwn90cj93201nixr2e1re]

Oh, ok, that's your choice. Also acceptable. Thanks.

[mikela-valve]

Actually, cl_autowepswitch is part of userinfo and anything else setting up player state also needs to be, so it's probably better to go with extending cl_autowepswitch. Since DMC has its own special logic already I'm not planning to change it so everything else will just treat 2 as switch if not attacking.

[afwn90cj93201nixr2e1re]

x D, i forgot about that.

[mikela-valve]

The beta branch is updated for HL1/HLDS and CS for the above changes.

[TheStormN]

@mikela-valve Once again, it does not work after respawn...

[mikela-valve]

@TheStormN Could you try uninstalling/reinstalling and double-checking that? I just ran through a few tests locally in HL1 with cl_autowepswitch 0 and 1 and each time it was still respected after respawn. Just to be sure I switched back to the crowbar for each test to ensure other weapons would have higher weight and each time it either switched or didn't switch as appropriate.

[TheStormN]

@mikela-valve Ok, I've used verify integrity of game files and now it is working as expected. Sorry for the false positive and thank you for the good work! :)

[mikela-valve]

Thanks @TheStormN! Closing as fixed.