Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proton: Installation of Assassin's Creed Brotherhood and AC:II #5649

Closed
Mushoz opened this issue Aug 23, 2018 · 25 comments
Closed

Proton: Installation of Assassin's Creed Brotherhood and AC:II #5649

Mushoz opened this issue Aug 23, 2018 · 25 comments

Comments

@Mushoz
Copy link

Mushoz commented Aug 23, 2018

Your system information

  • Steam client version (build number or date): Steam Beta, latest as of 23rd of August 2018
  • Distribution (e.g. Ubuntu): Antergos (Arch)
  • Opted into Steam client beta?: Yes
  • Have you checked for system updates?: Yes

Please describe your issue in as much detail as possible:

This issue was originally opened on the Proton issue tracker, but on second thought this seems to be an issue with Steam for Linux instead, since Wine/Proton doesn't even get to start, since the installation doesn't complete successfully. Orginal issue: ValveSoftware/Proton#68

I am trying out different games from my Steam library. Installing Assassin's Creed 1 works fine and plays correctly. However, when I try to install Assassin's Creed Brotherhood or Assassin's Creed: II a Window that says "Creating Local Game Files" pops up. This screen never completes.

In the background I do see the game being downloaded with progress going from 0% to 100%, however, said screen remains. I can only click "cancel" or the cross in the rightmost corner of the popup, but both will uninstall the game immediately.

FYI, Assassin's Creed Brotherhood runs fine when I run the Window's version of Steam through regular Wine. One thing I noticed is that this version uses Ubisoft Uplay Launcher to launch the game. Perhaps this is resulting in installation conflicts with Steam Play.

@Mushoz
Copy link
Author

Mushoz commented Aug 23, 2018

Killing the steam client gets rid of the perpetual "Creating Local Game Files" screen as a workaround. However, clicking play now results in a "Failed to request product key from Steam, please try again in a few minutes." popup.

Related: ValveSoftware/Proton#190

@unlimitedbacon
Copy link

I had the same issue when I installed the game, and I am also getting the "Failed to request product key" message when I try to play it. I also have the game installed on my Windows box. Is there a way to copy the product key from there and enter it manually?

@veikk0
Copy link

veikk0 commented Aug 28, 2018

Is there a way to copy the product key from there and enter it manually?

There is a "CD Key" entry in the links section when you select the game in Steam's library view. However, clicking it brings up that same Steam error pop-up that says "Failed to request product key from Steam, please try again in a few minutes." So it would seem this is a problem with retrieving the key at all, even manually, via the Steam Linux client.

@d4rkf4b
Copy link

d4rkf4b commented Aug 29, 2018

Have the same issues with "Driver: San Francisco"
Another drop of Ubisoft

@veikk0
Copy link

veikk0 commented Sep 14, 2018

If the CD key is the issue then #212 may be the cause.

@brandonrisell
Copy link

I'm seeing this with Assassins Creed II. Installs, but the "Creating local game files" popup stays up. I kill steam and reopen. When trying to launch the game, "Failed to request product key from Steam".

@jvetulani
Copy link

I'm getting the same with Assassin's Creed: Revelations

@Darklink999999
Copy link

I also have the same problem with AC II.

@Mushoz
Copy link
Author

Mushoz commented Mar 3, 2019

Still an issue for me as well. The game playes perfectly when I run the Windows version of steam itself in Wine, so it should definitely be playable. Would be a very happy man when I can ditch the Windows client completely and stuck with the native Linux steam client :)

@jomarocas
Copy link

any progress for this, this i am think is possible for fix, but nothing to progress for fix various games

@mohkale
Copy link

mohkale commented Jun 1, 2020

still definitely an issue.

@hsantos92
Copy link

totally still an issue!!

@cverstege
Copy link

I've tried some stuff but with no positive results. Maybe this helps the one at Valve trying to fix this issue. See #212 (comment)

@cverstege
Copy link

I think I found the cause of this Problem.

When installing Assassin's Creed 2 (https://steamdb.info/app/33230/) on Windows, it will only install the Windows CD Key DLC (https://steamdb.info/app/33361/), but not the Mac CD Key DLC (https://steamdb.info/app/33362/). It isn't even shown as an available DLC on the Windows Steam client.

In contrast, when installing the game on Linux, both CD Key DLCs are installed as well, but the Steam client can only fetch the Windows Key, but also wants to get the Mac key, as ShowCDKeyOnLaunch is set to true for both DLCs (see SteamDB links).

When launching the game on Windows, the Steam client will thus only try to get the Windows DLC Key, but the Linux client is trying to obtain the Windows and the Mac key on launch, which fails.

On Linux requesting the Windows Key with steam steam://cdkeys/33361 works just fine. Requestig the Mac key with steam steam://cdkeys/33362 will fail. Requesting the Mac Key on Windows will fail as well.
This is all expected behaviour I guess, as SteamPlay will only work with Windows titles.

So the problem here is that the steam Linux client wants to request all DLC keys when doing steam steam://cdkeys/33230 but would only need the Windows DLC keys, as SteamPlay/Proton does only support running Windows Titles.
This is probably a problem with the steam Play configuration, as the Linux client will install the Mac only DLC with the Mac Key but then fails to get the key on startup.

@Plagman I hope you can work with all this information :)

@belgianGeek
Copy link

I think I found the cause of this Problem.

When installing Assassin's Creed 2 (https://steamdb.info/app/33230/) on Windows, it will only install the Windows CD Key DLC (https://steamdb.info/app/33361/), but not the Mac CD Key DLC (https://steamdb.info/app/33362/). It isn't even shown as an available DLC on the Windows Steam client.

In contrast, when installing the game on Linux, both CD Key DLCs are installed as well, but the Steam client can only fetch the Windows Key, but also wants to get the Mac key, as ShowCDKeyOnLaunch is set to true for both DLCs (see SteamDB links).

When launching the game on Windows, the Steam client will thus only try to get the Windows DLC Key, but the Linux client is trying to obtain the Windows and the Mac key on launch, which fails.

On Linux requesting the Windows Key with steam steam://cdkeys/33361 works just fine. Requestig the Mac key with steam steam://cdkeys/33362 will fail. Requesting the Mac Key on Windows will fail as well.
This is all expected behaviour I guess, as SteamPlay will only work with Windows titles.

So the problem here is that the steam Linux client wants to request all DLC keys when doing steam steam://cdkeys/33230 but would only need the Windows DLC keys, as SteamPlay/Proton does only support running Windows Titles.
This is probably a problem with the steam Play configuration, as the Linux client will install the Mac only DLC with the Mac Key but then fails to get the key on startup.

@Plagman I hope you can work with all this information :)

Now I understand why the game won't launch, thank you ! Is there any way we can bypass this issue ?

@cverstege
Copy link

Now I understand why the game won't launch, thank you ! Is there any way we can bypass this issue ?

I don't think so. There apparently was a workaround by editing ~/.steam/steam/appcache/appinfo.vdf and altering the registry parts to prevent steam from going for the key. But an update earlier this year broke this workaround as the steam client is checking the integrity of this file at every launch.
Starting steam in offline mode doesn't help either as it only displayed Games from the Orange Box for me, after I've altered ~/.steam/steam/appcache/appinfo.vdf.

You can take a look at #212 (comment) and the following comments for things I've already tried. If you come up with another idea I will gladly try it.
I've posted my findings to all related issues for steam-for-linux and proton.

@mberndt123
Copy link

mberndt123 commented Apr 30, 2021

I'm having this problem too with Assassin's Creed II. And running the steam steam://cdkeys/33361 command from the console will retrieve the CD key just fine, only when I try to launch the actual game it will fail to retrieve the CD Key.

// edit:
I got this working. @tralph3's Steam-Metadata-Editor can be used to edit Steam metadata, but the relevant flags for this case aren't supported through the GUI. But I found a workaround:
First I changed the name of the "Assassin's Creed 2 - Mac" app to something else. This doesn't do anything useful by itself, but it does mean that this app will now show up in $HOME/.local/share/Steam-Metadata-Editor/config/modifications.json. I then used a text editor to modify that file. There's an original section and a modified section. In the latter, you set showcdkeyonlaunch to 0 and remove the legacykeyregistrylocation line. Then I closed the file and applied the changes using steammetadataeditor -s.

I can now launch the game and I no longer get the error message about not being have to retrieve the product key. Still, this should be fixed in Steam.

@thaewrapt
Copy link

steam steam://cdkeys/33361

Yeah, this command also works for me, I guess Steam just can't figure out that it needs this particular key to use when it's on Linux. The same happens for another affected Ubisoft title, Tom Clancy's Splinter Cell: Conviction, steam steam://cdkeys/33370 shows the key while other two methods ("Manage CD keys" by menu or starting the game from Steam) fail with the error mentioned above.

@pdfrod
Copy link

pdfrod commented May 2, 2021

@mberndt123 have you tried the workaround I suggested here?

@NathanaelA
Copy link

I want to comment on @mberndt123 solution, the https://github.com/tralph3/Steam-Metadata-Editor works great as long as you know where to put the showcdkeyonlaunch key...

So for me making the showcdkeyonlaunch: 0 does work at least for Assassins Creed Unity, however, a couple notes to expand:

  1. You need to apply it to any DLC you have -- as several of the DLC's for AC: Unity also has this flag set to 1 and they will cause it to continue to fail.
  2. For both the game and EACH DLC, The section you want to add it to is: "<STEAM_ID>" -> "modified" -> "appinfo" -> "extended" ----> "showcdkeyonlaunch: 0"

So the AC: Unity looks like (with all non-relevant sections stripped out):

{
  "289650": {
    "modified": {
       "appinfo": {
           "extended: {
              "showcdkeyonlaunch": 0
            }
        }
     }
  }
}

I just basically exported every single DLC and the game, and manually added the showcdkeyonlaunch: 0 to every one of the dlc's. In addition on keys that seemed questionable, I made changes... I'm not 100% if they are needed (but for completeness I'll list them here in case someone else finds that showcdkeyonlaunch: 0 alone doesn't solve AC: Unity)

          "legacykeyregistrationmethod": "registry",      <--- Deleted
          "legacykeyregistrationmethod": "api",             <--- Deleted
          "supportscdkeycopytoclipboard": 1,                <--- Changed to 0
          "legacykeylinkedexternally": 1                         <--- Changed to 0
          "legacykeyproofofpurchaseticket": 1,              <--- Changed to 0
          "proofofpurchaseticketrevision": 1                   <--- Changed to 0

Just a warning: I've played the game on windows before, so my steam account is linked to my ubisoft account, however those keys might still be needed if you have never played the game before....

@smintman
Copy link

Please please Valve can you resolve this we shouldn't need to hacking the files to get this to work, just correct the client incorrectly trying to request the Mac DLC!?!?

@smintman
Copy link

@Plagman can you confirm if this planned to be resolved on for the upcoming steamdeck steam client?, I think it will result in uwanted steam deck compatibilty failures for games that otherwise work fine!

@smintman
Copy link

The issue might be fixed, I updated my client (I'm on beta channel) and deleted the prefix and deleted the appcache.vdf (to clear any previous fixes) and I managed to start, update and play assassins creed 2 deluxe and brotherhood!
Also can request CD key without error!

Can others try to check the issue is resolved for them!!

@KnightOfCups
Copy link

Confirmed on #212

@kisak-valve
Copy link
Member

Closing as fixed in the 2022-05-12 Steam client update (uncredited).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests