Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Note renders malformed dbml #15

Closed
jens-koster opened this issue Jul 2, 2022 · 1 comment
Closed

Project Note renders malformed dbml #15

jens-koster opened this issue Jul 2, 2022 · 1 comment

Comments

@jens-koster
Copy link
Contributor

jens-koster commented Jul 2, 2022

parse the below as a file, the db.dbml property corrupts the format by putting curly braces around the note.
Project DocDWH {
database_type: 'BigQuery'
Note: '''
# document related tables
markdown content here
'''
}

turns into the below in the dbml-property:
Project DocDWH {
database_type: 'BigQuery'
Note: {'''
# document related tables
markdown content here
'''}
}

this will not load again in pydbml due to the curly braces (or on dbdiagram.io)
I fixed it in note.py, it is just a question of removing the curly braces form the output in the dbml property. Didn't think to make a pull request before changing a lot more stuff in my fork, sorry about that!

@Vanderhoof
Copy link
Owner

Thanks for finding this! I'll fix this in the next version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants