-
-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic browser support #32
Comments
By the way, that sign translator is really awesome!! |
Thank you for the quick response and information :) I have now created something to use the right muxer given browser support - https://github.com/sign/translate/blob/master/src/app/pages/translate/pose-viewers/playable-video-encoder.ts And you are right, safari does support this file, but for some reason, not before I download it. Very strange, I am not sure how to make this work (in Chrome everything works fine). Here's a reproduction of it not working, but supporting a file: muxer.mp4 |
Very sus, does this happen in all browsers, or just Safari? Is the Blob maybe incomplete or something when you first load it into the video, or slightly different when you then download it? Clearly, the video is valid and should play back just fine. |
A bug in safari. Here's my fix sign/translate@905b8cf#diff-4cca635d509f0a6c08cc233cc13337620521cda035bd4a935a83832775034fb8R93-R105 My apologies for opening this unrelated-to-this-library issue, I did not expect it to be a browser issue :) |
Browsers are still full of subtle media bugs, no problem! |
Using this library, I generate videos on the fly.
Then, I try to play the video in the browser.
In chrome desktop, it works, but on safari (desktop/mobile) or chrome mobile it doesn't.
See example file:
test.webm
I could not yet figure out why this is the case. I would like this library to support an
isPlayable
method, that given a Muxer determines if the video is playable or not. It should return eithertrue
,false
, ornull
.Quick mock implementation:
Or maybe, for example here, we specify
hasAlphaChannel: true
but thesupportedConfiguration
says no alpha is supported, we might be able tomakePlayable
by using the specified configurationThe text was updated successfully, but these errors were encountered: