Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat:[#299] Add browsers section #300

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Conversation

muhdsalm
Copy link
Contributor

@muhdsalm muhdsalm commented Jun 17, 2024

closes #299

@mirkobrombin mirkobrombin requested a review from matbme June 17, 2024 17:22
@matbme
Copy link
Member

matbme commented Jun 17, 2024

Currently, all browsers are selected by default. We should only ship one. Also, Epiphany is still inside Core Applications, I think we should move it into Browsers as well.

@muhdsalm
Copy link
Contributor Author

Currently, all browsers are selected by default. We should only ship one.

That's how the app category selection works. I'd suggest we revamp the entire page, given that it's a bit confusing to use, but that would be it's own issue

Also, Epiphany is still inside Core Applications, I think we should move it into Browsers as well.

Oh, I didn't see that. Let me fix it.

@mirkobrombin
Copy link
Member

Let's focus on the fix for the moment, we already have plans to revamp the first-setup and splitting the backend to a new utility

@mirkobrombin
Copy link
Member

Can you squash into a single commit?

Move Web from Core Applications to Browsers
@muhdsalm
Copy link
Contributor Author

Aye aye, cap'n!

@mirkobrombin mirkobrombin merged commit adea046 into Vanilla-OS:main Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Browsers section
3 participants