Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mute apt keys update #2240

Closed
Mte90 opened this issue Sep 8, 2020 · 4 comments
Closed

Mute apt keys update #2240

Mte90 opened this issue Sep 8, 2020 · 4 comments

Comments

@Mte90
Copy link
Member

Mte90 commented Sep 8, 2020

Now the output is:

    default:  * Updating apt keys
    default: gpg: key 3B4FE6ACC0B21F32: 3 signatures not checked due to missing keys
    default: gpg: key 3B4FE6ACC0B21F32: "Ubuntu Archive Automatic Signing Key (2012) <ftpmaster@ubuntu.com>" not changed
    default: gpg: key D94AA3F0EFE21092: 3 signatures not checked due to missing keys
    default: gpg: key D94AA3F0EFE21092: "Ubuntu CD Image Automatic Signing Key (2012) <cdimage@ubuntu.com>" not changed
    default: gpg: key 871920D1991BC93C: 1 signature not checked due to a missing key
    default: gpg: key 871920D1991BC93C: "Ubuntu Archive Automatic Signing Key (2018) <ftpmaster@ubuntu.com>" not changed
    default: gpg: Total number processed: 3
    default: gpg:              unchanged: 3
    default:  * Running apt-get update...
    default: Get:1 http://sgp1.mirrors.digitalocean.com/mariadb/repo/10.4/ubuntu bionic InRelease [6265 B]
    default: Get:2 https://deb.nodesource.com/node_10.x bionic InRelease [4584 B]
    default: Get:3 http://sgp1.mirrors.digitalocean.com/mariadb/repo/10.4/ubuntu bionic/main Sources [1746 B]

It should be enough

apt-key update -y
add in that line 2> /dev/null

@tomjn
Copy link
Member

tomjn commented Sep 8, 2020

wouldn't it be better to fix the problem than mute it?

@Mte90
Copy link
Member Author

Mte90 commented Sep 8, 2020

In my experience this happens because there are old keys not valid anymore so there are no issues.
The only would be remove all of them or a vagrant destroy so ignore that warning is not a problem.

@tomjn
Copy link
Member

tomjn commented Sep 8, 2020

the problem with muting is that if something goes horribly wrong, we'll have no idea as it'll be in neither the terminal output or the log file. I'd prefer we piped the output to the log file and didn't show it in the terminal, rather than pretending there was no output. Same goes for all the commands that currently use /dev/null, we should be moving away from it not towards it

@tomjn tomjn closed this as completed Sep 8, 2020
@tomjn
Copy link
Member

tomjn commented Sep 8, 2020

We'll take the same approach we use for site templates and utilities, everything goes in the log, but errors and progress messages go to the terminal. Hiding stuff just makes it impossible to debug when things go wrong

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants