Skip to content
This repository has been archived by the owner on Apr 9, 2023. It is now read-only.

Typo in README #40

Closed
noobidev opened this issue Apr 30, 2020 · 5 comments
Closed

Typo in README #40

noobidev opened this issue Apr 30, 2020 · 5 comments

Comments

@noobidev
Copy link

noobidev commented Apr 30, 2020

Describe the bug
Typo in README

Source
Readme

Error

public void startup(){
  DiscordEventHandlers handlers = new DiscordEventHandler.Build().setReadyEventHandler((user) -> {
      System.out.println("Welcome " + user.username + "#" + user.discriminator + "!");
  }).build();
  DiscordRPC.initialize("1234567890", handler, true);
}

->

public void startup(){
  DiscordEventHandlers handlers = new DiscordEventHandler.Build().setReadyEventHandler((user) -> {
      System.out.println("Welcome " + user.username + "#" + user.discriminator + "!");
  }).build();
  DiscordRPC.initialize("1234567890", handlers, true);
}

or

public void startup(){
  DiscordEventHandlers handler = new DiscordEventHandler.Build().setReadyEventHandler((user) -> {
      System.out.println("Welcome " + user.username + "#" + user.discriminator + "!");
  }).build();
  DiscordRPC.initialize("1234567890", handler, true);
}

Versions (Must be completed):

  • OS Ver: No
  • Java Version: No
  • Library Version: Master branch

Additional info
Typo in readme

@noobidev
Copy link
Author

noobidev commented May 9, 2020

@DeJayDev... Also change new DiscordEventHandler.Build() to new DiscordEventHandlers.Builder() because the class is named DiscordEventHandlers.

@Vatuu
Copy link
Owner

Vatuu commented May 9, 2020

No need, it's the handler object.

@noobidev
Copy link
Author

noobidev commented May 9, 2020

But the class DiscordEventHandlers.java is named DiscordEventHandlers 🤔

@noobidev
Copy link
Author

noobidev commented May 9, 2020

And it should be new DiscordEventHandlers.Builder() because the inner class is Builder and not Build

@noobidev
Copy link
Author

@Vatuu @DeJayDev?

@noobidev noobidev mentioned this issue May 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants