Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Defining an entry with no pages crashes the game on 1.16 #614

Open
blockgoblin31 opened this issue Oct 8, 2022 · 1 comment
Open

Defining an entry with no pages crashes the game on 1.16 #614

blockgoblin31 opened this issue Oct 8, 2022 · 1 comment
Labels
bug Something isn't working help wanted Pitch in and help the maintainers implement this!

Comments

@blockgoblin31
Copy link

blockgoblin31 commented Oct 8, 2022

Mod loader

Forge

Minecraft version

1.16.5

Patchouli version

1.16.4-53.3

Modloader version

Forge 36.2.34

Modpack info

https://github.com/tuc56/processing-pack/tree/patchouli-book

The latest.log file

https://gnomebot.dev/paste/1028101056074367076

Issue description

When loading an entry with no pages(in this case to make sure my icon is correct), you can open the entry fine, but upon trying to exit(I used shift click instead of normal click), the game crashes.

Steps to reproduce

  1. Define an entry with a valid name, icon, and category, but no pages
  2. reload your book and open the entry
  3. Shift click the back button to go back to the main page of the book

Other information

there are a few scripts that weren't on the github; I honestly don't remember what. the modlist.html includes everything, though.
The paste site is the one used when you upload a file in the modded minecraft discord. It's personally my favorite option for crash highlighting.

@blockgoblin31 blockgoblin31 added the bug Something isn't working label Oct 8, 2022
@williewillus williewillus changed the title Defining an entry with no pages crashes the game Defining an entry with no pages crashes the game on 1.16 Oct 16, 2022
@williewillus
Copy link
Member

Seems like not an issue on 1.19. Not sure I have time to get to it but if anyone wants to send a patch for it I'll apply it to 1.16 for the next bugfix release, whenever that will be.

@williewillus williewillus added the help wanted Pitch in and help the maintainers implement this! label Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Pitch in and help the maintainers implement this!
Development

No branches or pull requests

2 participants