Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.18.2][Compatibility] 'Item Sharing' module is not compatible with Chat Heads #3797

Closed
qznfbnj opened this issue Jun 27, 2022 · 1 comment

Comments

@qznfbnj
Copy link
Contributor

qznfbnj commented Jun 27, 2022

  1. Install Forge-1.18.2-40.1.52
  2. Install chat_heads-0.6.0-forge-1.18.1 alongside Quark-3.2-358
  3. Startup and crash

If comment out "client.ChatComponentMixin" in quark.mixins.json, game can run normally. But 'Render Items In Chat' function in 'Item Sharing' module will render nothing.
chatheads-quark
Because I can't figure out whose fault it is, I will submit to another at the same time: dzwdz/chat_heads#28.

Useless stuff:
Latest.log
Debug.log
Crash Report

@Fourmisain
Copy link

Fourmisain commented Jun 27, 2022

Chat Heads maintainer here, I fixed this on our end.

The issue was that Chat Heads targets the Font.drawShadow call that ChatComponentMixin redirects, so when Quark's mixin is loaded before Chat Heads' mixin, it won't be able to find the method.

Quark's @Redirect could be replaced by a @ModifyArgs for better compatibility, but it would make the code uglier (and a little bit less efficient), hence I just opted to adjust the Mixin priority on our side.

@qznfbnj qznfbnj closed this as completed Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants