Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export internal function #346

Closed
FrankXie05 opened this issue May 30, 2022 · 2 comments · Fixed by #347
Closed

Export internal function #346

FrankXie05 opened this issue May 30, 2022 · 2 comments · Fixed by #347

Comments

@FrankXie05
Copy link

Hello, I am the maintainer of vcpkg.
When updating the Vc version to 1.4.3, the CI test reported an error about the vc's support for triplet x64-uwp.
The reason may be the incorrect use of internal functions. I made a patch using the original definition of the function.
Expectation: Want to request upstream confirmation if it will affect the overall code structure and function usage.

Related:
[Vc] version: 1.4.3
Operating System : x64-uwp
vcpkg Pull Request: microsoft/vcpkg#24880
PATCH: https://github.com/microsoft/vcpkg/pull/24880/files#diff-c31805acd6fbfaabf2f902c37c3000e2960385deecaf31638282f5be2d7a3f0a

diff --git a/src/support_x86.cpp b/src/support_x86.cpp
index 0ab9669..d5c17ba 100644
--- a/src/support_x86.cpp
+++ b/src/support_x86.cpp
@@ -58,8 +58,9 @@ static inline bool xgetbvCheck(unsigned int bits)
 #endif
 }

-Vc_TARGET_NO_SIMD
-bool isImplementationSupported(Implementation impl)
+
+Vc_TARGET_NO_SIMD 
+bool Vc_VDECL isImplementationSupported(Vc::Implementation impl)
 {
     CpuId::init();

Failure logs:

D:\buildtrees\vc\src\1.4.3-2c1396b7e3.clean\src\support_x86.cpp(62): error C2373: 'Vc_1::isImplementationSupported': redefinition; different type modifiers
D:\buildtrees\vc\src\1.4.3-2c1396b7e3.clean\Vc/support.h(75): note: see declaration of 'Vc_1::isImplementationSupported'

Looking forward to your reply soon. :)

@bernhardmgruber bernhardmgruber linked a pull request May 30, 2022 that will close this issue
@bernhardmgruber
Copy link
Collaborator

Hi! Thank you so much for taking the time to find the cause for the build failure. I opened a PR to include your patch: #347.

@FrankXie05
Copy link
Author

@bernhardmgruber Sorry for the late reply, thank you for your prompt reply and PR. That's great. I can continue my PR. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants