Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight Block does not propagate to HLIL #2584

Open
gaasedelen opened this issue Aug 9, 2021 · 2 comments
Open

Highlight Block does not propagate to HLIL #2584

gaasedelen opened this issue Aug 9, 2021 · 2 comments
Labels
Component: API Issue needs changes to the API Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps

Comments

@gaasedelen
Copy link
Contributor

Binary Ninja Version

2.4.2921-dev

Describe the bug

No block-based highlights propagate to the HLIL view.

To Reproduce

Steps to reproduce the behavior:

  1. Highlight all the blocks in a function
  2. View the HLIL for the function
  3. None of the HLIL is highlighted in the function

Expected behavior

If I highlight blocks of instructions, I would expect these highlights to propagate to the HLIL. At least, in the same manner that individual instruction highlights currently propagate

Screenshots

This GIF demonstrates the issue:

highlight_binja_blocks

Version and Platform (required):

  • Binary Ninja: Dev 2.4.2921
  • OS: Windows
  • Version: Windows 8.1 (x64)

Additional context

N/A

@plafosse plafosse added Type: Bug Issue is a non-crashing bug with repro steps Impact: Medium Issue is impactful with a bad, or no, workaround labels Aug 11, 2021
@elbiazo
Copy link

elbiazo commented Sep 22, 2022

Not sure if this is true but is this issue the reason why Lighthouse isn't working on HLIL?

@gaasedelen
Copy link
Contributor Author

Not sure if this is true but is this issue the reason why Lighthouse isn't working on HLIL?

Yes.

Lighthouse does block-based highlighting in Binja because it is significantly faster to highlight thousands of blocks rather than millions of individual instructions. That said, Lighthouse is still much slower in Binja than IDA.

While it would be nice for this issue to be fixed, the ideal solution for Lighthouse would be a rendering callback that plugins could use from Binary Ninja to decide whether or not an instruction should be highlighted as it comes into view.

@fuzyll fuzyll added Component: UI Issue needs changes to the user interface Component: API Issue needs changes to the API labels May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: API Issue needs changes to the API Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Development

No branches or pull requests

4 participants