apply_auto_discovered_type

[ea]

Version and Platform (required):

• Version: 3.1.3523-dev
• OS: macOS
• OS Version: 12
• CPU Architecture x64

Bug Description:

Seems like apply_auto_discovered_type easily crashes whole Binary Ninja when trying to apply a type with unknown (or empty) struct. It seems to me like it crashes after the type is applied.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

1. Go to any function
2. make sure struct in_addr is NOT defined.
3. execute current_function.apply_auto_discovered_type("char *a (const struct in_addr *arg1, char *s);")
4. Binja should crash

Expected Behavior:
Expecting an error of some sort?

Additional Information:
This can obviously be worked around and it's my fault for not defining the struct first, but I thought i should report it.
Cheers!

[negasora]

I can't reproduce with 3.1.3539-dev

[ea]

Weird , here's how i reproduce it:

As soon as i hit return , crashes.
Attaching a crashdump as well in case that might be helpful, but i don't really see anything outright useful in it.

struct_crash_report.txt

[ea]

Should add, the above binary is just /bin/cat on macOS

[negasora]

Tried on a different binary and it repro'd, ty!

[negasora]

Fixed in 3.1.3542-dev