Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReadPointer method on BinaryReader #3657

Closed
0cyn opened this issue Nov 11, 2022 · 1 comment
Closed

ReadPointer method on BinaryReader #3657

0cyn opened this issue Nov 11, 2022 · 1 comment
Assignees
Labels
Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality
Milestone

Comments

@0cyn
Copy link
Member

0cyn commented Nov 11, 2022

What is the feature you'd like to have?
There are times when writing Architecture-Independent plugins where being able to avoid large amounts of (bv->GetAddressSize() == 4) and instead have the BinaryReader class handle this check internally would be highly beneficial.

This method could output a fixed size of uint64_t and truncate uint32_t or smaller pointers accordingly.

Is your feature request related to a problem?
This is directly applicable to this workflow_objc issue: Vector35/workflow_objc#11

It is also relevant in any plugin/implementation designed to perform analysis on both arm64 and armv7 binaries, and reduces the overhead for supporting non-uint64_t address sizes in general.

@0cyn 0cyn added the Type: Enhancement Issue is a small enhancement to existing functionality label Nov 11, 2022
@plafosse plafosse added Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels Jan 9, 2023
@0cyn
Copy link
Member Author

0cyn commented May 18, 2023

Resolved in builds >= 3.5.4286

@0cyn 0cyn closed this as completed May 18, 2023
@0cyn 0cyn added this to the Coruscant milestone May 18, 2023
@0cyn 0cyn self-assigned this May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants