Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BN does not render int128_t data in linear view #4059

Closed
op2786 opened this issue Mar 2, 2023 · 4 comments
Closed

BN does not render int128_t data in linear view #4059

op2786 opened this issue Mar 2, 2023 · 4 comments
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Linear Issues with the Linear view
Milestone

Comments

@op2786
Copy link
Contributor

op2786 commented Mar 2, 2023

Binary Ninja Version: 3.4.4090-dev
Platform: Windows 11 Version 22H2

It can be reproduced by defining a int128_t variable in anywhere in data section.

128t

@plafosse plafosse added Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels Mar 6, 2023
@psifertex psifertex added this to the Coruscant milestone Apr 25, 2023
@fuzyll fuzyll added Component: UI Issue needs changes to the user interface UI: Linear Issues with the Linear view labels May 17, 2023
@fuzyll fuzyll added the Type: Enhancement Issue is a small enhancement to existing functionality label Jul 3, 2023
@plafosse plafosse modified the milestones: Coruscant, Dorsai Aug 30, 2023
@ExecuteProtect
Copy link

Is this just related to its rendering or are the values broken when accessed from the api?

@fuzyll
Copy link
Contributor

fuzyll commented Oct 31, 2023

As far as I'm aware, it should just be rendering.

Also, the reason this hasn't been fixed yet is because the code uses int64_ts to pass the data around internally and...as you might imagine, 128 bits don't fit inside of that, so this is not, in fact, the 5-minute change I expected it to be when I looked at it last week. 🙃

@ExecuteProtect
Copy link

That response was just perfect, thanks for the explanation on both what the problem is and why it hasn't been closed, it's good to know that this was actually looked into.

@D0ntPanic
Copy link
Member

This was true for any data type that doesn't have a valid data renderer (including any integer type greater than 8 bytes or not a power of 2 in size). Fixed in 3.6.4749.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Linear Issues with the Linear view
Projects
None yet
Development

No branches or pull requests

6 participants