Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary resize-ability in add segment window and wrong buttons #4175

Closed
blue-devil opened this issue Mar 30, 2023 · 2 comments
Closed

Unnecessary resize-ability in add segment window and wrong buttons #4175

blue-devil opened this issue Mar 30, 2023 · 2 comments
Assignees
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround UI: Dialogs Issues with smaller dialogs

Comments

@blue-devil
Copy link

Version and Platform (required):

  • Binary Ninja Version: 3.4.4170-dev
  • OS: Windows 10, x64

Bug Description:
Please see the screenshot that I have recorded.

  • Add segment window can be resized downwards but it is unnecessary.
  • Buttons Add and Cancel is not proper qt buttons I think?

Steps To Reproduce:

1.Open BN and load and executable
2. Click Memory Map
3. Right click on Memory Map windows
4. Click on Add Segment in the right-click context menu
5. Resize the Add segment window

Expected Behavior:

  • I expect normal qt buttons like in the assembly window or in the Help > About window
  • I expect add segment window not to resize downward. I think Add segment window should be fixed in size.
  • Read, write, execute checkboxes should be fixed

Screenshots:
add_segment_bug

@plafosse plafosse added Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels Apr 3, 2023
@fuzyll fuzyll added Component: UI Issue needs changes to the user interface UI: Dialogs Issues with smaller dialogs labels May 16, 2023
@fuzyll fuzyll self-assigned this May 25, 2023
@fuzyll fuzyll added this to the Coruscant milestone May 25, 2023
@fuzyll
Copy link
Contributor

fuzyll commented May 25, 2023

This should be fixed in builds >= 3.5.4299, please let me know if there's anything else you see that's wrong.

@fuzyll fuzyll closed this as completed May 25, 2023
@blue-devil
Copy link
Author

I have checked the latest dev build and it is fixed, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround UI: Dialogs Issues with smaller dialogs
Projects
None yet
Development

No branches or pull requests

3 participants