Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with union selection inside a struct #4218

Closed
0xFDFDFDFD opened this issue Apr 14, 2023 · 2 comments
Closed

Issues with union selection inside a struct #4218

0xFDFDFDFD opened this issue Apr 14, 2023 · 2 comments
Labels
State: Duplicate Issue is a duplicate of another issue

Comments

@0xFDFDFDFD
Copy link

0xFDFDFDFD commented Apr 14, 2023

Version and Platform (required):

  • Binary Ninja Version: 3.4.4224-dev Personal
  • OS: Manjaro Linux
  • CPU Architecture: x86_64

Bug Description:
When reversing a windows driver module I cannot select which union inside a struct is displayed. But it just displays it as an offset instead of CurrentStackLocation or PacketType.
Additionally the IL views are not consistent in displaying unions. High IL doesnt show any union while medium and low IL detects the Overlay struct but the sub types cannot be defined.
Steps To Reproduce:

  1. Load a windows kernel driver module
  2. Define the IRP struct (Import it from wdm.h)
  3. Try to select the union type inside Tail

Expected Behavior:
It is possible to select the union type and is not just written as an offset. In this case it should be currentstacklocation
Screenshots:

high_level_il

low_level_il

part_ of_IRP_struct

@op2786
Copy link
Contributor

op2786 commented Apr 14, 2023

Could be related to #1013. Better union support is an urgent thing in my opinion.

@plafosse plafosse added the State: Duplicate Issue is a duplicate of another issue label May 30, 2023
@plafosse
Copy link
Member

Duplicate of #1013

@plafosse plafosse marked this as a duplicate of #1013 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
State: Duplicate Issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

3 participants