Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag icon in linear view gets duplicated when view frame width gets small #4307

Closed
kristopax opened this issue May 19, 2023 · 1 comment
Closed
Assignees
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Linear Issues with the Linear view UI: Tags Issues with the Tags widget
Milestone

Comments

@kristopax
Copy link
Member

Version and Platform (required):

  • Binary Ninja Version: Latest dev
  • OS: MacOS
  • OS Version: Monterey
  • CPU Architecture: M1 Max

Bug Description:
Tag icon in Linear View gets duplicated when the view frame width is squeezed small enough to cause the line to wrap to multiple lines.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Open any binary
  2. Navigate to a function start
  3. Select Linear View
  4. Right click -> Tags and Bookmarks -> Add Tag
  5. Select Needs Analysis tag
  6. Change the horizontal window size to shrink the view until the function signature wraps to multiple lines
  7. Verify that the '?' Tag icon is duplicated when the function signature line wraps

Expected Behavior:
I expected only one tag icon to be displayed when the function signature wraps to multiple lines.

Screenshots:
Screen Shot 2023-05-18 at 10 57 47 PM

@kristopax kristopax added Type: Bug Issue is a non-crashing bug with repro steps Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day UI: Tags Issues with the Tags widget UI: Linear Issues with the Linear view labels May 19, 2023
@kristopax kristopax added this to the Coruscant milestone May 19, 2023
@plafosse plafosse modified the milestones: Coruscant, Dorsai May 24, 2023
@xusheng6
Copy link
Member

xusheng6 commented Aug 9, 2023

Screenshot 2023-08-09 at 3 30 53 PM

The funny part of this bug is that we are rendering one more tag on each line down in the stack. The first line has one tag, the second has two, and the fifth line has five tags!

@xusheng6 xusheng6 closed this as completed Aug 9, 2023
@xusheng6 xusheng6 modified the milestones: Dorsai, Coruscant Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Linear Issues with the Linear view UI: Tags Issues with the Tags widget
Projects
None yet
Development

No branches or pull requests

3 participants