Shipped API files don't include python/binaryninja/py.typed #4318
Labels
Component: API
Issue needs changes to the API
Effort: Trivial
Issue should take < 1 day
Impact: Low
Issue is a papercut or has a good, supported workaround
Type: Enhancement
Issue is a small enhancement to existing functionality
Milestone
Version and Platform (required):
Bug Description:
Using the type annotations requires manually creating an empty file at
python/binaryninja/py.typed
, despite the fact that this repo includes such a file.Steps To Reproduce:
scripts/install_api.py
cd ~/tmp && echo 'import binaryninja' > meow.py && mypy meow.py
python/binaryninja/py.typed
within the binaryninja installationmypy meow.py
and observe it now works.Expected Behavior:
mypy
works out of the box, withpy.typed
shipped with the rest of Binary Ninja.Additional Information:
See also: #2747.
While I can't find it now, I seem to recall seeing an issue where the problem was that empty
py.typed
files get stripped by the build process, which is why there's now a dummy comment in them. Nonetheless, this doesn't seem to be helping, as they are still not included.The text was updated successfully, but these errors were encountered: