Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remember selected log category across restarts #4389

Closed
jonpalmisc opened this issue Jun 6, 2023 · 3 comments
Closed

Remember selected log category across restarts #4389

jonpalmisc opened this issue Jun 6, 2023 · 3 comments
Assignees
Labels
Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Logs Issues with the Log area
Milestone

Comments

@jonpalmisc
Copy link
Contributor

It would be helpful if there were a way to make the log category selection (BinaryView.MachoView in the picture below) stay selected across restarts.

image

This is particularly helpful when you are developing a new plugin and are frequently checking debug messages, etc., but don't care about the log output of anything else.

Right now, to test my changes to my plugin, I have to restart Binary Ninja, reopen a file, then re-select the log category. The first two steps are obviously necessary, but avoiding the last one would be a nice quality of life improvement.

@fuzyll fuzyll added Component: UI Issue needs changes to the user interface and removed Component: UI Issue needs changes to the user interface labels Jun 6, 2023
@psifertex
Copy link
Member

Re-opening a file is not required!

Use the "restart and reopen files" action.

Instead of only doing it on restart, I'll just make that filter sticky in general across both restarts and tabs.

Resolved in builds >= 3.5.4319

@psifertex psifertex self-assigned this Jun 6, 2023
@psifertex psifertex added UI: Logs Issues with the Log area Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day Type: Enhancement Issue is a small enhancement to existing functionality labels Jun 6, 2023
@psifertex psifertex added this to the Coruscant milestone Jun 6, 2023
@plafosse
Copy link
Member

The commit that added this caused a major UI performance regression and had to be reverted.

@plafosse plafosse reopened this Jun 22, 2023
@fuzyll fuzyll self-assigned this Jun 22, 2023
@fuzyll
Copy link
Contributor

fuzyll commented Jun 22, 2023

This should be fixed in builds >= 3.5.4352, but with better performance this time. Please comment on this issue if you notice performance issues again, or any other edge cases, with the new implementation.

@fuzyll fuzyll closed this as completed Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality UI: Logs Issues with the Log area
Projects
None yet
Development

No branches or pull requests

4 participants