database_viewer plugin sometimes fails to load

[alexrp]

Version and Platform (required):

• Binary Ninja Version: 3.5.4402-dev Personal (c2f291a7)
• OS: Windows
• OS Version: 10.0.25375.1
• CPU Architecture: x64

Bug Description:

Loaded native plugin cryptoplugin
Loaded native plugin dwarf_export
Loaded native plugin dwarf_import
Loaded native plugin idb_import_plugin
Loaded native plugin view_elf
Loaded native plugin view_macho
Loaded native plugin view_pe
Loaded native plugin arch_arm64
Loaded native plugin arch_armv7
Loaded native plugin arch_mips
Loaded native plugin arch_ppc
Loaded native plugin arch_x86
Loaded native plugin pdb_import_plugin
Loaded native plugin platform_decree
Loaded native plugin platform_efi
Loaded native plugin platform_freebsd
Loaded native plugin platform_linux
Loaded native plugin platform_mac
Loaded native plugin platform_windows
Loaded native plugin workflow_objc
Loaded native plugin debuggercore
Loaded python3 plugin 'ClassyPP'
Loaded python3 plugin 'cryptoscan'
Loaded python3 plugin 'binsync_binsync'
Loaded python3 plugin 'skr0x1c0_ipybinja'
Loaded python3 plugin 'Vector35_kaitai'
Loaded python3 plugin 'Vector35_snippets'
Loaded python3 plugin 'Vector35_sigkit'
Loaded native plugin pythonplugin
UI plugin database_viewer failed to load
Loaded UI plugin debuggerui

Steps To Reproduce:
It seems to just happen randomly when opening BN. Most of the time, it loads fine.

Expected Behavior:
No failure.

[xusheng6]

Good catch, we are missing a return value in UIPluginInit. Should be an easy fix

[xusheng6]

Also just a reminder that the database viewer plugin is considered very raw at the moment so it is not ready for public consumption