Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improved stack structure aliasing #4544

Closed
psifertex opened this issue Aug 2, 2023 · 2 comments
Closed

improved stack structure aliasing #4544

psifertex opened this issue Aug 2, 2023 · 2 comments
Assignees
@D0ntPanic
Labels
Component: Core Issue needs changes to the core Core: HLIL Issue involves High Level IL Effort: Medium Issue should take < 1 month Impact: High Issue adds or blocks important functionality Type: Enhancement Issue is a small enhancement to existing functionality
Milestone
Coruscant

Comments

@psifertex
Copy link
Member

This is believed to be a major component of many reports of Dead Code Elimination problems, remains to be seen once this fix is implemented how many other related issues are fixed.
@psifertex psifertex added this to the Coruscant milestone Aug 2, 2023
@psifertex psifertex added Impact: Medium Issue is impactful with a bad, or no, workaround Impact: High Issue adds or blocks important functionality Effort: Medium Issue should take < 1 month Core: HLIL Issue involves High Level IL and removed Impact: Medium Issue is impactful with a bad, or no, workaround labels Aug 2, 2023
@CouleeApps
Copy link
Member

Relevant: #2219 #773 possibly #3049

@fuzyll fuzyll added Component: Core Issue needs changes to the core Type: Enhancement Issue is a small enhancement to existing functionality labels Aug 7, 2023
@D0ntPanic
Copy link
Member

Added in build 4469. Uses much more conservative constant propagation for stack variables when there is stack variable aliasing present. Dead code elimination should be much improved in functions with stack structures, though in some cases constant propagation through stack variables will no longer occur.

@psifertex psifertex mentioned this issue Oct 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@D0ntPanic D0ntPanic

Labels
Component: Core Issue needs changes to the core Core: HLIL Issue involves High Level IL Effort: Medium Issue should take < 1 month Impact: High Issue adds or blocks important functionality Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Milestone
Coruscant
Development

No branches or pull requests
4 participants
@psifertex @fuzyll @CouleeApps @D0ntPanic