Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component class is not hashable #4636

Closed
kristopax opened this issue Sep 20, 2023 · 1 comment
Closed

Component class is not hashable #4636

kristopax opened this issue Sep 20, 2023 · 1 comment
Labels
Component: API Issue needs changes to the API Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality
Milestone

Comments

@kristopax
Copy link
Member

kristopax commented Sep 20, 2023

What is the feature you'd like to have?
I would like for the Python Component class to be hashable via hash method implementation.

Is your feature request related to a problem?
On Sidekick, we are currently having to manually define an implementation instead of just using one provided by the class.

Are any alternative solutions acceptable?
This is what we are currently doing on Sidekick to achieve the desired feature:

Component.__hash__ = lambda self: cast(Component, self).guid.__hash__()

@kristopax kristopax added Type: Enhancement Issue is a small enhancement to existing functionality Component: API Issue needs changes to the API Impact: Low Issue is a papercut or has a good, supported workaround Effort: Trivial Issue should take < 1 day labels Sep 20, 2023
@kristopax kristopax added this to the Dorsai milestone Sep 20, 2023
@plafosse
Copy link
Member

Fixed on dev. I didn't cause a build to be generated should be fixed in >= 3.6.4775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: API Issue needs changes to the API Effort: Trivial Issue should take < 1 day Impact: Low Issue is a papercut or has a good, supported workaround Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants