Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on context menu after selecting a variable in linear view then navigating #4647

Closed
CouleeApps opened this issue Sep 22, 2023 · 2 comments
Closed

Crash on context menu after selecting a variable in linear view then navigating #4647

CouleeApps opened this issue Sep 22, 2023 · 2 comments
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: High Issue adds or blocks important functionality Type: Crash Issue is a crash or deadlock UI: Linear Issues with the Linear view

Comments

@CouleeApps
Copy link
Member

Version and Platform (required):

  • Binary Ninja Version: 3.5.4526 (stable)
  • OS: Windows
  • OS Version: 11
  • CPU Architecture: x64

Bug Description:
In certain cases, trying to right click the types view crashes after a specific set of actions in linear view.

Steps To Reproduce:

  1. Open this binary: animals.exe.zip
  2. Navigate to 00401f80
  3. Double click the the Fly token in the variable in the signature
  4. Under Xrefs -> Data References, double click the vtable reference
  5. Right click in Types View
  6. Program crashes

Expected Behavior:
I expected the program not to crash.

Additional Information:
Looks like m_highlight.localVarValid is not being cleared on navigation away from the function, and then getCurrentFunction() returns nullptr and crashes.
@CouleeApps CouleeApps added Component: UI Issue needs changes to the user interface Type: Crash Issue is a crash or deadlock Impact: High Issue adds or blocks important functionality Effort: Trivial Issue should take < 1 day UI: Linear Issues with the Linear view labels Sep 22, 2023
@CouleeApps
Copy link
Member Author

Will be fixed in 3.6.4554-dev

@wildex999
Copy link

Tested on 3.6.4554-dev any my case no longer crashes :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: UI Issue needs changes to the user interface Effort: Trivial Issue should take < 1 day Impact: High Issue adds or blocks important functionality Type: Crash Issue is a crash or deadlock UI: Linear Issues with the Linear view
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CouleeApps @wildex999