Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linear Feature Map rendering is broken #4722

Closed
CouleeApps opened this issue Nov 1, 2023 · 3 comments
Closed

Linear Feature Map rendering is broken #4722

CouleeApps opened this issue Nov 1, 2023 · 3 comments
Assignees
@negasora
Labels
Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Feature Map Issues with the Feature Map widget
Milestone
Dorsai

Comments

@CouleeApps
Copy link
Member

CouleeApps commented Nov 1, 2023 •
edited

Version and Platform (required):

  • Binary Ninja Version: 3.6.4599
  • OS: macOS
  • OS Version: 14
  • CPU Architecture: M1

Bug Description:
Trying to use the feature map in Linear mode causes rendering issues

Steps To Reproduce:

  1. Open a binary (might have to be > 1MB)
  2. Notice feature map is not linear, despite having Linear Feature Map setting enabled (probably a different bug)
  3. Right click feature map and enable Linear Feature Map
  4. Realize the repaint didn't clear the old feature map
  5. Try resizing the window and watch it glitch out

Expected Behavior:
I expected it to not look broken

Screenshots:
image
image
image
image
@CouleeApps CouleeApps added Type: Bug Issue is a non-crashing bug with repro steps Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround UI: Feature Map Issues with the Feature Map widget labels Nov 1, 2023
@negasora
Copy link
Member

negasora commented Feb 14, 2024 •
edited

This is because qt does not handle images larger than 32767px in either direction properly. The feature map should work on a reasonably-sized image and calculate coordinates accordingly instead of operating on a massive image then scaling down.

@negasora negasora self-assigned this Feb 14, 2024
@negasora
Copy link
Member

negasora commented Feb 14, 2024 •
edited

fixed in 4.0.4883-dev

@plafosse plafosse added this to the Dorsai milestone Feb 14, 2024
@CouleeApps
Copy link
Member Author

Looks way better! Thanks for the fix

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@negasora negasora

Labels
Component: UI Issue needs changes to the user interface Impact: Medium Issue is impactful with a bad, or no, workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Feature Map Issues with the Feature Map widget
Projects
None yet
Milestone
Dorsai
Development

No branches or pull requests
3 participants
@CouleeApps @negasora @plafosse