Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type system entirely broken in mac-thumb2 platform binaries. #4817

Closed
0cyn opened this issue Dec 10, 2023 · 1 comment
Closed

Type system entirely broken in mac-thumb2 platform binaries. #4817

0cyn opened this issue Dec 10, 2023 · 1 comment
Assignees
@0cyn
Labels
Component: Core Issue needs changes to the core Effort: Low Issue should take < 1 week Impact: Critical Issue blocks CRITICAL functionality Type: Bug Issue is a non-crashing bug with repro steps

Comments

@0cyn
Copy link
Member

0cyn commented Dec 10, 2023

Version and Platform (required):

  • Binary Ninja Version: 3.6.4654
  • OS: macOS

Bug Description:
The type system does not work at all in mac-thumb2 platform binaries. Types cannot be changed.

The following error is provided:

[Platform] Failed to parse platform types for file: /Applications/Binary Ninja.app/Contents/MacOS/plugins/../../Resources/types/platform/mac-thumb2.c

Steps To Reproduce:

  1. Open Attached Binary
  2. Try to change any type

identityservicesd-ios10.zip

Additional Information:
Type view edit dialog shows an empty error box when trying to change types. If you missed the error amidst the deluge of thumb2-related MachoView warnings, this may be confusing.
@fuzyll fuzyll added Type: Bug Issue is a non-crashing bug with repro steps Component: Core Issue needs changes to the core labels Dec 12, 2023
@0cyn 0cyn added Effort: Low Issue should take < 1 week Impact: Critical Issue blocks CRITICAL functionality labels Jan 6, 2024
@0cyn 0cyn assigned 0cyn and unassigned CouleeApps Jan 6, 2024
@0cyn
Copy link
Member Author

0cyn commented Jan 6, 2024

Fixed in dev builds >= 3.6.4751

@0cyn 0cyn closed this as completed Jan 6, 2024
@CouleeApps CouleeApps mentioned this issue Jan 6, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0cyn 0cyn

Labels
Component: Core Issue needs changes to the core Effort: Low Issue should take < 1 week Impact: Critical Issue blocks CRITICAL functionality Type: Bug Issue is a non-crashing bug with repro steps
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fuzyll @CouleeApps @0cyn