Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetOpenFileNameInput with projects does not allow filter by extension #4953

Closed
CouleeApps opened this issue Jan 24, 2024 · 1 comment
Closed

GetOpenFileNameInput with projects does not allow filter by extension #4953

CouleeApps opened this issue Jan 24, 2024 · 1 comment
Assignees
@negasora
Labels
Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Projects Issues with the Projects tab or related widgets
Milestone
Dorsai

Comments

@CouleeApps
Copy link
Member

Version and Platform (required):

  • Binary Ninja Version: 3.6.4789
  • OS: macOS
  • OS Version: 14.0
  • CPU Architecture: M1

Bug Description:
When using BinaryNinja::GetOpenFileNameInput to open files in projects, the file extension filter I specified is not honored and I am allowed to select any file I please. This is confusing since now it looks like I can pick any file I want, even though normally they would not be displayed (and indeed because they will not work). This dialog should hide files (but not folders) with an extension other than the one I specified.

Steps To Reproduce:
Please provide all steps required to reproduce the behavior:

  1. Make some code using the BinaryNinja::GetOpenFileNameInput api with an extension filter
  2. Open a project
  3. Trigger your code
  4. Observe all files are allowed to be selected

Expected Behavior:
I expected the dialog to hide files (but not folders) with an extension other than the one I specified.
@CouleeApps CouleeApps added Type: Bug Issue is a non-crashing bug with repro steps Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround UI: Projects Issues with the Projects tab or related widgets labels Jan 24, 2024
@negasora negasora self-assigned this Jan 25, 2024
@negasora negasora added this to the Dorsai milestone Jan 25, 2024
@negasora
Copy link
Member

Added in 3.6.4796-dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@negasora negasora

Labels
Component: UI Issue needs changes to the user interface Impact: Low Issue is a papercut or has a good, supported workaround Type: Bug Issue is a non-crashing bug with repro steps UI: Projects Issues with the Projects tab or related widgets
Projects
None yet
Milestone
Dorsai
Development

No branches or pull requests
2 participants
@CouleeApps @negasora