Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Highlighting in IL views #811

Closed
erhlee-bird opened this issue Sep 26, 2017 · 8 comments
Closed

Support Highlighting in IL views #811

erhlee-bird opened this issue Sep 26, 2017 · 8 comments
Labels
Component: UI Issue needs changes to the user interface Type: Enhancement Issue is a small enhancement to existing functionality
Milestone

Comments

@erhlee-bird
Copy link

I can highlight disassembly basic blocks, but cannot for at least medium level il blocks.

>>> current_function.medium_level_il.basic_blocks[0].highlight
<color: none, alpha 0>
>>> current_function.medium_level_il.basic_blocks[0].highlight = HighlightStandardColor.BlueHighlightColor
>>> current_function.medium_level_il.basic_blocks[0].highlight
<color: none, alpha 0>

vs

>>> current_function.basic_blocks[0].highlight
<color: none, alpha 0>
>>> current_function.basic_blocks[0].highlight = HighlightStandardColor.BlueHighlightColor
>>> current_function.basic_blocks[0].highlight
<color: blue>

Binary Ninja Version: 1.1.923-dev, 7bf8ca42
Platform: Linux

@erhlee-bird
Copy link
Author

This behavior is consistent with right clicking and setting block colors in the GUI as well.

@psifertex
Copy link
Member

Correct -- highlighting is not currently supported in these views. Marking as 1.2.

@psifertex psifertex changed the title Cannot Highlight Medium Level IL Basic Blocks Support Highlighting in IL views Sep 26, 2017
@psifertex psifertex added Type: Enhancement Issue is a small enhancement to existing functionality Component: UI Issue needs changes to the user interface labels Sep 26, 2017
@psifertex psifertex added this to the v1.2 milestone Sep 26, 2017
@psifertex
Copy link
Member

Thanks -- I thought we had a bug tracking this already but couldn't find it.

@erhlee-bird
Copy link
Author

No worries, thanks for the quick response!

@plafosse
Copy link
Member

Added in v1.1.1428

@yuv422
Copy link

yuv422 commented Jan 4, 2019

This doesn't appear to be working for me in Version 1.1.1461-dev Personal (Build ID 435d8566)

Platform MacOSX

current_function.medium_level_il.basic_blocks[0].highlight
<color: none, alpha 0>
 current_function.medium_level_il.basic_blocks[0].highlight = HighlightStandardColor.BlueHighlightColor
current_function.medium_level_il.basic_blocks[0].highlight
<color: none, alpha 0>

@psifertex
Copy link
Member

Yeah, I can confirm it's not working as well. Re-opening.

@psifertex psifertex reopened this Feb 28, 2019
@rssor
Copy link
Member

rssor commented Mar 12, 2019

Resolved as of build 1.1.1543-dev. It is worth noting that highlights are only stored/loaded in terms of the native block, so all multiple IL blocks derived from one native block will share a highlight.

@rssor rssor closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: UI Issue needs changes to the user interface Type: Enhancement Issue is a small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

5 participants