Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not an issues but a request. Change numbering #69

Open
Docwho1983 opened this issue May 31, 2023 · 3 comments
Open

Not an issues but a request. Change numbering #69

Docwho1983 opened this issue May 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@Docwho1983
Copy link

Could we add 00 in front of the 1-9 fleets and then 0 infront of the 10-99 fleets?

So that the fleets will line up correctly in the fleet list. Just to make life easier.

Thanks.

@Vectorial1024
Copy link
Owner

Hi there!

X4's engine do not have good string support (at least this is my impression) so if we want to do this, we will have to hard-code the logic for 0-9, 10-99, and the remaining (i.e., the default case).

And I think we can do this.

We will have to look at the relevant code:

https://github.com/Vectorial1024/v1024_civilian_fleets/blob/88f18708d5ba68235cd8a60a4163e57da35a2abd/md/civilianfleets_signals.xml#L750C25-L753

And add if-cases to it. This also means we will have to add in extra language strings in the t-folders.

@Vectorial1024 Vectorial1024 added the enhancement New feature or request label Jun 2, 2023
@Vectorial1024
Copy link
Owner

In theory, there will be at most around 10-20 civilian fleets in operation at the same time (late game will probably see them converted into station traders for better management), but realistically, fleet numbers will likely reach the 3-digits when fleet leaders start dying to enemy ships in the end-late game.

Some thoughts:

  • really review the fleet number assignment script
  • apply the "000" formatting up to fleet number 999

@Vectorial1024
Copy link
Owner

This has some interesting implications; if this works in a general way, then #22 will become sensible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants