Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPPTokenConnection not able to customize ClientID #55

Closed
FooBarWidget opened this issue Jul 8, 2021 · 2 comments · Fixed by #56
Closed

TPPTokenConnection not able to customize ClientID #55

FooBarWidget opened this issue Jul 8, 2021 · 2 comments · Fixed by #56
Assignees
Labels
bug Something isn't working

Comments

@FooBarWidget
Copy link

TPPTokenConnection always sends client_id value equal to vcert-sdk. Paul Cleary requested that our products use a different client_id value, for tracking purposes to tell which integrations are seeing the most use in your customer base.

However, TPPTokenConnection does not allow customizing client_id. TPPTokenConnection's constructor creates an Authentication object with only very limited customization options. The client which constructs TPPTokenConnection is not able to customize the Authentication object's client_id option.

@FooBarWidget FooBarWidget added the bug Something isn't working label Jul 8, 2021
@tr1ck3r
Copy link
Member

tr1ck3r commented Jul 8, 2021

It is indeed expected that the VCert consumer may, and almost always will, override the value of client_id when requesting a new token because the client_id is a unique identifier that represents the API integrated application in Trust Protection Platform for managing access.

@rvelaVenafi
Copy link
Contributor

The client_id can be changed by creating a new Authentication object and requesting a new access token.
We added the default client id as convenience for the users.
A demo has been added to examples folder for this purpose.

The client id has not been exposed to the general Connection object because, at this moment, it does not apply for VaaS platform. When that happens, we can reconsider exposing it as part of the optional Connection arguments.

@rvelaVenafi rvelaVenafi mentioned this issue Jul 9, 2021
@rvelaVenafi rvelaVenafi linked a pull request Jul 9, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants