Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait please #17

Closed
Flynsarmy opened this issue Jul 11, 2013 · 4 comments
Closed

Trait please #17

Flynsarmy opened this issue Jul 11, 2013 · 4 comments

Comments

@Flynsarmy
Copy link

Could we also get a Revisionable trait for those of us already extending our models?

@duellsy
Copy link
Member

duellsy commented Aug 1, 2013

Apologies for the late reply, I've been away on a break. That's a great idea, not sure how the best way to do it in the current version would be, but the next version of the package I think it could makes sense to create it as a trait.
Thanks.

@duellsy duellsy closed this as completed Aug 1, 2013
@cjke
Copy link

cjke commented Feb 26, 2014

Can you consider not enforcing Traits though, as it would break 5.3 compatibility

@duellsy
Copy link
Member

duellsy commented Feb 26, 2014

@cjke I've actually already done work on this, however it's not forced that you need to use a trait, it is now just an option. You can use as is (for 5.3), or as a trait (for 5.4+)

#36

@Flynsarmy
Copy link
Author

Thanks @duellsy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants