Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add to CDN #124

Closed
jehna opened this issue Jan 11, 2016 · 7 comments
Closed

Add to CDN #124

jehna opened this issue Jan 11, 2016 · 7 comments

Comments

@jehna
Copy link
Contributor

jehna commented Jan 11, 2016

Related to #123

@tomByrer
Copy link
Contributor

I can do that for you (I happen to volunteer for jsDelivr OSS CDN. I'm fairly certain that our @120 POPs should be sufficient ;)

But I prefer to host only minified files, so I hope you upload those. Many tools are available to help, even online.

Good news is if you tag releases & upload minified files to GitHub, then it easy to configure our bot to automate all update uploads to jsDelivr for you.

@mackenza
Copy link
Contributor

@tomByrer there is already a grunt job in the release to produce a minified library. Does the CDN also house map files usually?

@tomByrer
Copy link
Contributor

That's great you have the script ready to compress, but the actual verbalexpressions.min.js output needs to be hosted in the GH repo. Our bot is not strong enough to run grunt or gulp tasks. :/

BTW, I've seen issues with mixed case filenames; best practice to use only lowercase.
ractivejs/ractive#527 (comment)

Sure, we're happy to host .map files.

@tomByrer
Copy link
Contributor

(BTW, thanks for already including a header comment in the .min.js & ending the IIFE with a ;; both help prevent problems.)

@softwarespot
Copy link
Contributor

Once done, I can then look at using a grunt umd wrapper instead, which I was looking at the other day, but made no sense if the user had to build the library themselves.

@mihai-vlc
Copy link
Contributor

@tomByrer a PR was created for this jsdelivr/jsdelivr#8882
A new release was created: https://github.com/VerbalExpressions/JSVerbalExpressions/releases/tag/0.2.0

@mihai-vlc
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants