Fixing the handling of (unmatched) optional capture groups #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when an optional capture group is actually not matched
since it no longer supports jdk's older than 9: > $ ~/bin/install-jdk.sh --target "/home/travis/oraclejdk8" --workspace "/home/travis/.cache/install-jdk" --feature "8" --license "BCL" > Ignoring license option: BCL -- using GPLv2+CE by default > install-jdk.sh 2020-06-02 > Expected feature release number in range of 9 to 16, but got: 8
|
👀 |
|
Any response from any of the maintainers? @lanwen ? |
lanwen
reviewed
Mar 19, 2021
lanwen
reviewed
Mar 19, 2021
|
Hey, @simschla, thanks a lot for this change - I'm about to accept it, sorry for the delay - I missed this PR somehow. This is a breaking change, however I feel it's a correct one. Could you answer two small questions? |
Co-authored-by: Kirill Merkushev <lanwen@yandex.ru>
|
Thanks for the review @lanwen. Just answered your questions above, let me know if there is anything else I can do 👍 |
|
released as 1.8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into an issue where I have a capture group defined, that is actually optional. Whenever that group cannot be matched (which is ok since it is optional) the
regex.getText(testString, "optionalCaptureGroupName")call would return a string literal"null"instead of an empty string"".This PR provides a test showcasing the problem and a code adaption fixing the issue.