Conversation
@timperrett @stew Could we also get a release if/when this gets in? :) |
weird errors coming from travis CI:
I don't believe that has anything doing with this PR. |
ee0a5aa
to
1c9ebe2
Compare
@ahjohannessen this doesnt even compile for me locally. I get the following:
|
@timperrett that is really strange :/ What kind of JDK and OS do you have there? Compiles fine here for 2.10 and 2.11, I am on OS X Yosemite and have JDK8. |
7c9fa01
to
66c5c10
Compare
- upgrade scodec to 1.8.1 and thereby shapeless to 2.2.4 - upgrade scodec-scalaz to 1.1.0 in order to match scodec upgrade. - fix `DescribeSpec` wrt. casing. - bump travis jdk versions.
66c5c10
to
c803070
Compare
@timperrett could you try now to compile and run tests locally, that strange error should be gone now. I bumped to scodec 1.8.1 that depends on shapeless 2.2.4. Note, I have force pushed in order to get travis to build the PR, you probably need to delete the PR branch and fetch again if you have one still. |
btw, Travis CI is a bit flaky. |
ping @timperrett :) |
@ahjohannessen my bad, had an old JDK on the mac i used before. |
@timperrett thanks Timothy :) it would be nice with a new remotely release :) |
@ahjohannessen sure, i'll update the build and push one out |
@ahjohannessen so the project tests no longer pass for some reason? I cant look into it right now, but perhaps you have some cycles? The failing test is below - i've also updated the build to match our other projects in order to streamline the release process.
|
@timperrett That is odd, I do not get that specific error locally. This commit passes both on 2.10 and 2.11 for me, but current master code gives me some issues in tests with regards to an error being thrown. Not sure what is going on. |
If I downgrade ScalaCheck back to 1.11.6 then current master passes all tests in 2.10 and 2.11 and no error is being thrown. |
@ahjohannessen its released :-) do note the change in group-id and artifact id: |
@timperrett super! :) |
scodec upgrade.
DescribeSpec
wrt. casing error.