Skip to content
This repository has been archived by the owner on Mar 11, 2020. It is now read-only.

build: upgrades #86

Merged
merged 1 commit into from Jul 25, 2015
Merged

Conversation

ahjohannessen
Copy link
Contributor

  • upgrade scodec to 1.8.1 and thereby shapeless to 2.2.4.
  • upgrade scodec-scalaz to 1.1.0 in order to match
    scodec upgrade.
  • fix DescribeSpec wrt. casing error.
  • bump travis jdk version.

@ahjohannessen
Copy link
Contributor Author

@timperrett @stew Could we also get a release if/when this gets in? :)

@ahjohannessen
Copy link
Contributor Author

weird errors coming from travis CI:

[error] /home/travis/build/oncue/remotely/examples/src/main/scala/Protocol.scala:25: exception during macro expansion: 
[error] java.lang.ClassNotFoundException: java.nio.charset.StandardCharsets

I don't believe that has anything doing with this PR.

@ahjohannessen ahjohannessen force-pushed the wip-upgrade-scodec18 branch 2 times, most recently from ee0a5aa to 1c9ebe2 Compare June 20, 2015 15:49
@ahjohannessen ahjohannessen changed the title build: upgrade scodec & fix failing test build: upgrades Jun 20, 2015
@timperrett
Copy link
Contributor

@ahjohannessen this doesnt even compile for me locally. I get the following:

[error] /Users/timperrett/sandbox/scala/ahjohannessen-remotely/examples/src/main/scala/Protocol.scala:25: exception during macro expansion:
[error] java.lang.ClassNotFoundException: java.nio.charset.StandardCharsets
[error]     at java.net.URLClassLoader$1.run(URLClassLoader.java:202)
[error]     at java.security.AccessController.doPrivileged(Native Method)
[error]     at java.net.URLClassLoader.findClass(URLClassLoader.java:190)
[error]     at java.lang.ClassLoader.loadClass(ClassLoader.java:306)
[error]     at java.lang.ClassLoader.loadClass(ClassLoader.java:247)
[error]     at scodec.codecs.package$.<init>(package.scala:452)
[error]     at scodec.codecs.package$.<clinit>(package.scala)
[error]     at remotely.codecs.package$.<init>(codecs.scala:48)
[error]     at remotely.codecs.package$.<clinit>(codecs.scala)
[error]     at remotely.Codecs$.<init>(Codecs.scala:46)
[error]     at remotely.Codecs$.<clinit>(Codecs.scala)
[error]     at remotely.Protocol$.<init>(Protocol.scala:56)
[error]     at remotely.Protocol$.<clinit>(Protocol.scala)
[error]     at __wrapper$1$a107ea65e29d4e0897dbed66118eca35.__wrapper$1$a107ea65e29d4e0897dbed66118eca35$.wrapper(<no source file>:25)
[error]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[error]     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[error]     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[error]     at java.lang.reflect.Method.invoke(Method.java:597)
[error]     at scala.tools.reflect.ToolBoxFactory$ToolBoxImpl$ToolBoxGlobal$$anonfun$compile$1.apply(ToolBoxFactory.scala:271)
[error]     at scala.tools.reflect.ToolBoxFactory$ToolBoxImpl.eval(ToolBoxFactory.scala:436)
[error]     at scala.reflect.macros.runtime.Evals$class.eval(Evals.scala:16)
[error]     at scala.reflect.macros.runtime.Context.eval(Context.scala:6)
[error]     at remotely.GenServer$.impl(GenServer.scala:47)
[error] @GenServer(remotely.Protocol.empty.codec[Int].specify1("fac", Field.strict[Int]("in"), Type[Int]))
[error]  ^
[error] /Users/timperrett/sandbox/scala/ahjohannessen-remotely/examples/src/main/scala/Protocol.scala:30: exception during macro expansion:
[error] java.lang.NoClassDefFoundError: Could not initialize class remotely.Protocol$
[error]     at __wrapper$1$1f0d05e367554422b5b1348a671df812.__wrapper$1$1f0d05e367554422b5b1348a671df812$.wrapper(<no source file>:30)
[error]     at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[error]     at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
[error]     at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
[error]     at java.lang.reflect.Method.invoke(Method.java:597)
[error]     at scala.tools.reflect.ToolBoxFactory$ToolBoxImpl$ToolBoxGlobal$$anonfun$compile$1.apply(ToolBoxFactory.scala:271)
[error]     at scala.tools.reflect.ToolBoxFactory$ToolBoxImpl.eval(ToolBoxFactory.scala:436)
[error]     at scala.reflect.macros.runtime.Evals$class.eval(Evals.scala:16)
[error]     at scala.reflect.macros.runtime.Context.eval(Context.scala:6)
[error]     at remotely.GenClient$.impl(GenClient.scala:40)
[error] @GenClient(remotely.Protocol.empty.codec[Int].specify1[Int,Int]("fac", Field.strict[Int]("in"), Type[Int]).signatures)
[error]  ^
[error] /Users/timperrett/sandbox/scala/ahjohannessen-remotely/examples/src/main/scala/Protocol.scala:44: value environment is not a member of remotely.examples.FacServer{val fac: Int => remotely.Response[Int]}
[error]   lazy val env = facServer.environment
[error]                            ^
[error] three errors found
[info] Compiling 1 Scala source to /Users/timperrett/sandbox/scala/ahjohannessen-remotely/test/target/scala-2.10/classes...
[info] Compiling 12 Scala sources to /Users/timperrett/sandbox/scala/ahjohannessen-remotely/core/target/scala-2.10/test-classes...
[warn] /Users/timperrett/sandbox/scala/ahjohannessen-remotely/core/src/test/scala/SSLSpec.scala:213: discarded non-Unit value
[warn]       an[Exception] should be thrownBy fact.run
[warn]                                             ^

@ahjohannessen
Copy link
Contributor Author

@timperrett that is really strange :/ What kind of JDK and OS do you have there? Compiles fine here for 2.10 and 2.11, I am on OS X Yosemite and have JDK8.

@ahjohannessen ahjohannessen force-pushed the wip-upgrade-scodec18 branch 2 times, most recently from 7c9fa01 to 66c5c10 Compare July 9, 2015 11:36
 - upgrade scodec to 1.8.1 and thereby shapeless to 2.2.4

 - upgrade scodec-scalaz to 1.1.0 in order to match
   scodec upgrade.

 - fix `DescribeSpec` wrt. casing.

 - bump travis jdk versions.
@ahjohannessen
Copy link
Contributor Author

@timperrett could you try now to compile and run tests locally, that strange error should be gone now. I bumped to scodec 1.8.1 that depends on shapeless 2.2.4. Note, I have force pushed in order to get travis to build the PR, you probably need to delete the PR branch and fetch again if you have one still.

@ahjohannessen
Copy link
Contributor Author

btw, Travis CI is a bit flaky.

@ahjohannessen
Copy link
Contributor Author

ping @timperrett :)

@timperrett
Copy link
Contributor

@ahjohannessen my bad, had an old JDK on the mac i used before.

timperrett added a commit that referenced this pull request Jul 25, 2015
@timperrett timperrett merged commit ef8c797 into Verizon:master Jul 25, 2015
@ahjohannessen
Copy link
Contributor Author

@timperrett thanks Timothy :) it would be nice with a new remotely release :)

@timperrett
Copy link
Contributor

@ahjohannessen sure, i'll update the build and push one out

@timperrett
Copy link
Contributor

@ahjohannessen so the project tests no longer pass for some reason? I cant look into it right now, but perhaps you have some cycles? The failing test is below - i've also updated the build to match our other projects in order to streamline the release process.

[info] ! Remote.roundtrip[Double]: Exception raised on property evaluation.
[info] > ARG_0: List()
[info] > ARG_1: Map()
[info] > Exception: java.lang.IllegalStateException: Pool not open
[info] + TupleCodec.tupele2Codec works: OK, passed 100 tests.

@ahjohannessen
Copy link
Contributor Author

@timperrett That is odd, I do not get that specific error locally. This commit passes both on 2.10 and 2.11 for me, but current master code gives me some issues in tests with regards to an error being thrown. Not sure what is going on.

@ahjohannessen
Copy link
Contributor Author

If I downgrade ScalaCheck back to 1.11.6 then current master passes all tests in 2.10 and 2.11 and no error is being thrown.

@timperrett
Copy link
Contributor

@ahjohannessen its released :-) do note the change in group-id and artifact id:
"oncue.remotely" %% "core" % "1.4.0"

@ahjohannessen
Copy link
Contributor Author

@timperrett super! :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants