This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
CPM improvements #12
Merged
CPM improvements #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiMoskvin
force-pushed
the
OMSDK-2024/cpm-improvements
branch
from
b5a92af
to
6b0293c
Compare
Current coverage for OathVideoPartnerSDK.framework is
|
| Files changed | - | - |
|---|---|---|
| AdMetrics.swift | 0.00% |
💀 |
| TrackingPixelsConnector_Ad.swift | 0.00% |
💀 |
| TrackingPixelsReporter.swift | 0.00% |
💀 |
| AdVRMEngine.swift | 2.19% |
💀 |
| VRMProvider.swift | 12.50% |
💀 |
| VRMRequestController.swift | 96.39% |
✅ |
Current coverage for PlayerCore.framework is 54.08%
✅ No files affecting coverage found
Powered by xcov
Generated by 🚫 Danger
|
@VladyslavAnokhin Ready for review! |
VladyslavAnokhin
previously approved these changes
Dec 20, 2018
AndriiMoskvin
force-pushed
the
OMSDK-2024/cpm-improvements
branch
2 times, most recently
from
c4874ed
to
5683f86
Compare
AndriiMoskvin
force-pushed
the
OMSDK-2024/cpm-improvements
branch
from
5683f86
to
36c2045
Compare
AndriiMoskvin
force-pushed
the
OMSDK-2024/cpm-improvements
branch
from
36c2045
to
e646b61
Compare
VladyslavAnokhin
approved these changes
Dec 21, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPM improvements - main changes inside PlayerCore submodule