This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Finish group controller #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| final class FinishVRMGroupProcessingController { | ||
| let dispatch: (PlayerCore.Action) -> () | ||
| var finishedGroupIds = Set<VRMCore.Group.ID>() |
AndriiMoskvin
previously approved these changes
Jan 22, 2019
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| VVPSDK.swift | 0.00% |
💀 |
| FinishVRMGroupProcessingController.swift | 26.32% |
🚫 |
| StartVRMGroupProcessingController.swift | 37.50% |
🚫 |
Powered by xcov
Generated by 🚫 Danger
VladyslavAnokhin
force-pushed
the
OMSDK-2153/finish-group-contorller
branch
3 times, most recently
from
ac3c2bb
to
b325844
Compare
VladyslavAnokhin
force-pushed
the
OMSDK-2153/finish-group-contorller
branch
from
b325844
to
ebb0e40
Compare
AndriiMoskvin
approved these changes
Jan 22, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Added controller which finishes group in case of:
JIRA Ticket
@VerizonAdPlatforms/video-partner-sdk-developers: Please review.