This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Moved wrapper processing from item controller to processing controller #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VladyslavAnokhin
force-pushed
the
OMSDK-2163/add-vrm-processing-detector
branch
from
1833f23
to
6675f34
Compare
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| VVPSDK.swift | 0.00% |
💀 |
| VRMProcessingController.swift | 75.00% |
|
| VRMItemController.swift | 85.71% |
✅ |
Powered by xcov
Generated by 🚫 Danger
balavor
previously approved these changes
Jan 31, 2019
| dispatch(VRMCore.timeoutError(item: item)) | ||
| } else if case .inline(let vast) = result.vastModel { | ||
| dispatch(VRMCore.selectInlineVAST(item: item, inlineVAST: vast)) | ||
| } else if case .wrapper(let wrapper) = result.vastModel { | ||
| dispatch(VRMCore.unwrapItem(item: item, url: wrapper.tagURL)) | ||
| guard let count = scheduledVRMItems[item]?.count else { | ||
| assertionFailure("try to unwrap item, which wasn't started") |
There was a problem hiding this comment.
fatalError vs assertionFailure? What is the difference?
There was a problem hiding this comment.
the assertions are ignored in release builds
AndriiMoskvin
previously approved these changes
Jan 31, 2019
VladyslavAnokhin
dismissed stale reviews from AndriiMoskvin and balavor
via
41d3760
VladyslavAnokhin
force-pushed
the
OMSDK-2163/add-vrm-processing-detector
branch
from
6675f34
to
41d3760
Compare
balavor
approved these changes
Jan 31, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change will help to detect
ad-engine-request@VerizonAdPlatforms/video-partner-sdk-developers: Please review.