This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
ad-engine-request should be fired only for item, not wrapper #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| guard let first = result.first else { | ||
| XCTFail() |
There was a problem hiding this comment.
Human readable description why it failed?
AndriiMoskvin
previously approved these changes
Feb 4, 2019
balavor
previously approved these changes
Feb 4, 2019
VladyslavAnokhin
dismissed stale reviews from balavor and AndriiMoskvin
via
d059f93
VladyslavAnokhin
force-pushed
the
OMSDK-2212/update-ad-engine-request-detector
branch
from
b75166e
to
d059f93
Compare
balavor
approved these changes
Feb 4, 2019
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| AdEngineRequestDetector.swift | 55.56% |
Powered by xcov
Generated by 🚫 Danger
VladyslavAnokhin
deleted the
OMSDK-2212/update-ad-engine-request-detector
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In case of unwrapping an item haven't to send any
ad-engine-request@VerizonAdPlatforms/video-partner-sdk-developers: Please review.