This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Fix issue with slot opp detector #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriiMoskvin
previously requested changes
Feb 6, 2019
balavor
previously approved these changes
Feb 6, 2019
VladyslavAnokhin
dismissed
AndriiMoskvin’s stale review
Fixed critical issue in the description :)
VladyslavAnokhin
force-pushed
the
OMSDK-2224/fix-slot-opp-detector
branch
from
2d83da0
to
52d6431
Compare
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| TrackingPixelsConnector_Ad.swift | 0.00% |
💀 |
| PlayerProperties_Init.swift | 89.34% |
✅ |
Powered by xcov
Generated by 🚫 Danger
VladyslavAnokhin
force-pushed
the
OMSDK-2224/fix-slot-opp-detector
branch
from
52d6431
to
9911178
Compare
VladyslavAnokhin
force-pushed
the
OMSDK-2224/fix-slot-opp-detector
branch
from
9911178
to
adb52a4
Compare
balavor
approved these changes
Feb 6, 2019
AndriiMoskvin
approved these changes
Feb 6, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Slot opp didn't fire for videos with two and more ads.
@VerizonAdPlatforms/video-partner-sdk-developers: Please review.