This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Added parsing of skip offset for VAST ad #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balavor
force-pushed
the
OMSDK-2236/skip-offset-parsing
branch
from
fe13e4d
to
21199de
Compare
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| VASTModel.swift | 0.00% |
💀 |
| VASTParser.swift | 99.71% |
✅ |
Powered by xcov
Generated by 🚫 Danger
AndriiMoskvin
previously requested changes
Feb 11, 2019
balavor
force-pushed
the
OMSDK-2236/skip-offset-parsing
branch
from
21199de
to
4cc5ac0
Compare
|
@AndriiMoskvin @VladyslavAnokhin I've added logic to check date format that we get in VAST. |
balavor
force-pushed
the
OMSDK-2236/skip-offset-parsing
branch
2 times, most recently
from
371f8b7
to
09c0ec9
Compare
AndriiMoskvin
previously requested changes
Feb 11, 2019
balavor
force-pushed
the
OMSDK-2236/skip-offset-parsing
branch
from
09c0ec9
to
696cc24
Compare
balavor
force-pushed
the
OMSDK-2236/skip-offset-parsing
branch
3 times, most recently
from
016984b
to
75b75a5
Compare
balavor
force-pushed
the
OMSDK-2236/skip-offset-parsing
branch
from
75b75a5
to
7079d04
Compare
VladyslavAnokhin
approved these changes
Feb 12, 2019
AndriiMoskvin
approved these changes
Feb 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
@VerizonAdPlatforms/video-partner-sdk-developers: Please review.