Skip to content
This repository has been archived by the owner on Apr 26, 2023. It is now read-only.

Renamed skipAd action to dropAd #65

Merged
merged 1 commit into from
Feb 12, 2019
Merged

Renamed skipAd action to dropAd #65

merged 1 commit into from
Feb 12, 2019

Conversation

balavor
Copy link
Contributor

@balavor balavor commented Feb 12, 2019 •
edited
Loading

Changes

  • skipAd action replaced with dropAd action.

@VerizonAdPlatforms/video-partner-sdk-developers: Please review.

@balavor balavor self-assigned this Feb 12, 2019
@vvp-sdk-bot
Copy link

vvp-sdk-bot commented Feb 12, 2019 •
edited
Loading

Current coverage for PlayerCore.framework is 54.71%

✅ No files affecting coverage found

Current coverage for VerizonVideoPartnerSDK.framework is 36.48%

Files changed - -
VVPSDK.swift 0.00% 💀
PlayerInterface.swift 6.45% 💀
MidrollDetector.swift 84.48% ✅
AdManagerPresenter.swift 100.00% ✅

Powered by xcov

Generated by 🚫 Danger

AndriiMoskvin
AndriiMoskvin previously approved these changes Feb 12, 2019
View reviewed changes
@balavor balavor force-pushed the OMSDK-2245/ignore-ad branch 2 times, most recently from 2116ac8 to 271202a Compare February 12, 2019 13:53
@balavor balavor changed the title Renamed skipAd action to ignoreAd Renamed skipAd action to dropAd Feb 12, 2019
@balavor balavor merged commit 1f8553e into master Feb 12, 2019
@balavor balavor deleted the OMSDK-2245/ignore-ad branch February 12, 2019 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@VladyslavAnokhin VladyslavAnokhin VladyslavAnokhin approved these changes

@AndriiMoskvin AndriiMoskvin AndriiMoskvin left review comments

Assignees

@balavor balavor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balavor @vvp-sdk-bot @AndriiMoskvin @VladyslavAnokhin