Skip to content
This repository has been archived by the owner on Apr 26, 2023. It is now read-only.

Added script to lint podspec only if necessary #93

Merged
merged 1 commit into from
Mar 18, 2019
Merged

Added script to lint podspec only if necessary #93

merged 1 commit into from
Mar 18, 2019

Conversation

balavor
Copy link
Contributor

@balavor balavor commented Mar 12, 2019

@VerizonAdPlatforms/video-partner-sdk-developers: Please review.

@balavor balavor added the wip Work in progress label Mar 12, 2019
@balavor balavor self-assigned this Mar 12, 2019
@vvp-sdk-bot
Copy link

vvp-sdk-bot commented Mar 12, 2019 •
edited
Loading

Current coverage for PlayerCore.framework is 54.46%

✅ No files affecting coverage found

Current coverage for VerizonVideoPartnerSDK.framework is 38.72%

✅ No files affecting coverage found

Powered by xcov

Generated by 🚫 Danger

@balavor balavor force-pushed the VSDK-4596/podspec-linting-script branch 2 times, most recently from 7a24c3f to 629e95d Compare March 12, 2019 15:30
@balavor balavor removed the wip Work in progress label Mar 12, 2019
@balavor
Copy link
Contributor Author

balavor commented Mar 12, 2019

@AndriiMoskvin @VladyslavAnokhin RFR

AndriiMoskvin
AndriiMoskvin previously approved these changes Mar 12, 2019
View reviewed changes
Copy link
Contributor

@AndriiMoskvin AndriiMoskvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in the build-scripts - consider creating ticket to improve this.

@balavor balavor force-pushed the VSDK-4596/podspec-linting-script branch from e3878e5 to ebf2e26 Compare March 12, 2019 17:29
@balavor
Copy link
Contributor Author

balavor commented Mar 12, 2019

Done

AndriiMoskvin
AndriiMoskvin previously approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@AndriiMoskvin AndriiMoskvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still think this should be moved to the build scripts repo.

@balavor balavor force-pushed the VSDK-4596/podspec-linting-script branch from ebf2e26 to 61f595d Compare March 14, 2019 10:34
@VladyslavAnokhin
Copy link
Contributor

wip - it's a bad comment message

@balavor
Copy link
Contributor Author

balavor commented Mar 14, 2019 •
edited
Loading

It is still wip because that script is not working in fastlane

@AndriiMoskvin
Copy link
Contributor

Still not working?

@AndriiMoskvin AndriiMoskvin force-pushed the VSDK-4596/podspec-linting-script branch 2 times, most recently from 27ff8c8 to c3425c2 Compare March 15, 2019 10:59
@balavor balavor force-pushed the VSDK-4596/podspec-linting-script branch from c3425c2 to 3676fab Compare March 15, 2019 12:42
@AndriiMoskvin AndriiMoskvin force-pushed the VSDK-4596/podspec-linting-script branch from 3676fab to a5a309d Compare March 15, 2019 13:25
@balavor balavor force-pushed the VSDK-4596/podspec-linting-script branch from 6c300a4 to 8f091c4 Compare March 15, 2019 14:05
@AndriiMoskvin AndriiMoskvin force-pushed the VSDK-4596/podspec-linting-script branch 2 times, most recently from 6c300a4 to a5a309d Compare March 15, 2019 14:36
@balavor balavor force-pushed the VSDK-4596/podspec-linting-script branch from a5a309d to b6ed78e Compare March 18, 2019 10:02
@balavor balavor force-pushed the VSDK-4596/podspec-linting-script branch from b6ed78e to 335fcdb Compare March 18, 2019 10:03
@balavor balavor merged commit 842d120 into master Mar 18, 2019
@balavor balavor deleted the VSDK-4596/podspec-linting-script branch March 18, 2019 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AndriiMoskvin AndriiMoskvin AndriiMoskvin approved these changes

@VladyslavAnokhin VladyslavAnokhin Awaiting requested review from VladyslavAnokhin

Assignees

@balavor balavor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balavor @vvp-sdk-bot @VladyslavAnokhin @AndriiMoskvin