This repository has been archived by the owner on Apr 26, 2023. It is now read-only.
Handled isFailoverEnabled in selectFinalResult controller #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sources/advertisements/VRM New Core/Controllers/VRMSelectFinalResultController.swift
Outdated
Show resolved
Hide resolved
sources/advertisements/VRM New Core/Controllers/VRMSelectFinalResultController.swift
Outdated
Show resolved
Hide resolved
balavor
force-pushed
the
VSDK-4591/failover-feature-handling
branch
from
6042868
to
1d7a7dc
Compare
balavor
force-pushed
the
VSDK-4591/failover-feature-handling
branch
from
1d7a7dc
to
a3c869d
Compare
VladyslavAnokhin
approved these changes
Mar 12, 2019
VladyslavAnokhin
approved these changes
Mar 12, 2019
Current coverage for PlayerCore.framework is
|
| Files changed | - | - |
|---|---|---|
| VVPSDK.swift | 0.00% |
💀 |
| StartVRMGroupProcessingController.swift | 30.00% |
🚫 |
| VRMSelectFinalResultController.swift | 68.18% |
Powered by xcov
Generated by 🚫 Danger
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
If failover feature is disabled, we will handle only one final result.
@VerizonAdPlatforms/video-partner-sdk-developers: Please review.