Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: org name validation #151

Merged
merged 8 commits into from
Jul 16, 2021
Merged

fix: org name validation #151

merged 8 commits into from
Jul 16, 2021

Conversation

Kirpal
Copy link
Contributor

@Kirpal Kirpal commented Jul 15, 2021

Description

When trying to use the new --org-name support I found that underscores were not being supported. After looking a little closer, the regex for the org name was incorrect by not enforcing that segments must start with a letter and by enforcing a min/max of three segments.

I updated the org name regex, invalid org error message, and added more tests for edge cases.

Sources:

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before this can be merged we will need to update the template to support dynamic length for org name parts.

@felangel felangel merged commit 65c5ea6 into main Jul 16, 2021
@felangel felangel deleted the fix/org-name-validation branch July 16, 2021 03:44
@felangel felangel added the bug Something isn't working as expected label Jul 16, 2021
@felangel felangel mentioned this pull request Jul 16, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants